[https://nvbugs/5997534][fix] AutoDeploy: Skip Eagle3 One Model Test on pre-Hopper#12757
[https://nvbugs/5997534][fix] AutoDeploy: Skip Eagle3 One Model Test on pre-Hopper#12757govind-ramnarayan wants to merge 5 commits intoNVIDIA:mainfrom
Conversation
|
/bot help |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe changes migrate test-skipping logic from a waiver file entry to a code-level decorator for a specific test case. The import statement is updated to include the required skip decorator, which is then applied to the test method, and the corresponding waiver entry is removed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run --disable-fail-fast |
|
PR_Github #41773 [ run ] triggered by Bot. Commit: |
|
PR_Github #41773 [ run ] completed with state
|
…and unwaive Eagle3 acceptance rate threshold (25%) is calibrated for Hopper hardware where the draft model was trained. On L20 (Ada, SM 89) the acceptance rate is ~22%, which is functional but below the threshold. Skip the test on pre-Hopper GPUs and remove the global waive so it resumes running on Hopper+. Signed-off-by: Govind Ramnarayan <105831528+govind-ramnarayan@users.noreply.github.com>
718c512 to
f452c40
Compare
|
/bot run --disable-fail-fast |
|
/bot run |
|
/bot run --disable-fail-fast |
|
PR_Github #42003 [ run ] triggered by Bot. Commit: |
|
PR_Github #42004 [ run ] triggered by Bot. Commit: |
|
PR_Github #42003 [ run ] completed with state |
|
PR_Github #42004 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #42026 [ run ] triggered by Bot. Commit: |
|
PR_Github #42026 [ run ] completed with state
|
Signed-off-by: gramnarayan <105831528+govind-ramnarayan@users.noreply.github.com>
|
/bot run --disable-fail-fast |
|
PR_Github #42392 [ run ] triggered by Bot. Commit: |
|
PR_Github #42392 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #42561 [ run ] triggered by Bot. Commit: |
Signed-off-by: gramnarayan <105831528+govind-ramnarayan@users.noreply.github.com>
|
/bot run --disable-fail-fast |
|
PR_Github #42660 [ run ] triggered by Bot. Commit: |
Eagle3 acceptance rate threshold (25%) in accuracy test is calibrated for H100s (with a generous leeway). Slightly lower acceptance rate than this on different (especially older) hardware is fine. The test is meant to verify that Eagle3 wrapper code is working properly in AutoDeploy, so we want to flag lower-than-expected acceptance rates on hardware, not guarantee that it performs well on all hardware.
Tested on an L20 in ComputeLab:
Summary by CodeRabbit
Release Notes
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.