Skip to content

[None][chore] Add failed cases into waives.txt#12765

Merged
jieli-matrix merged 2 commits intoNVIDIA:mainfrom
jieli-matrix:user/qa/post_update_waive_20260405_LLM_FUNCTION_TEST_2034
Apr 9, 2026
Merged

[None][chore] Add failed cases into waives.txt#12765
jieli-matrix merged 2 commits intoNVIDIA:mainfrom
jieli-matrix:user/qa/post_update_waive_20260405_LLM_FUNCTION_TEST_2034

Conversation

@xinhe-nv
Copy link
Copy Markdown
Collaborator

@xinhe-nv xinhe-nv commented Apr 5, 2026

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Updated test skip configurations to waive specific test cases pending resolution of reported issues.

Note: This release contains only internal testing infrastructure updates with no user-facing changes.

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>
…ION_TEST_2034

Signed-off-by: Jie Li <76780849+jieli-matrix@users.noreply.github.com>
@jieli-matrix jieli-matrix marked this pull request as ready for review April 8, 2026 09:14
@jieli-matrix jieli-matrix assigned jieli-matrix and unassigned xinhe-nv Apr 8, 2026
@jieli-matrix jieli-matrix enabled auto-merge (squash) April 8, 2026 09:15
@jieli-matrix
Copy link
Copy Markdown
Collaborator

/bot run --stage-list ""

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c528791e-ba74-4803-8bb8-78b719b67536

📥 Commits

Reviewing files that changed from the base of the PR and between 04cf885 and a51e997.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

Two waived SKIP entries are added to the integration test waives list for accuracy/test_llm_api_pytorch.py::TestGPTOSS::test_w4_4gpus with specific parameter configurations, both referencing bug ticket 6026678.

Changes

Cohort / File(s) Summary
Test Waives List
tests/integration/test_lists/waives.txt
Added two SKIP entries for TestGPTOSS test with parameters v1_kv_cache-dp4-triton-auto and v1_kv_cache-ep4-triton-auto, both linked to nvbugs/6026678.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is minimal and lacks required sections such as detailed explanation of why changes were needed, test coverage information, and completion of the PR checklist. Expand the description to explain which test cases failed and why they need to be waived, include test coverage details, and complete the PR checklist items.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately describes the main change: adding failed test cases to the waives.txt file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42313 [ run ] triggered by Bot. Commit: a51e997 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42313 [ run ] completed with state SUCCESS. Commit: a51e997
/LLM/main/L0_MergeRequest_PR pipeline #33104 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@jieli-matrix
Copy link
Copy Markdown
Collaborator

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42347 [ reuse-pipeline ] triggered by Bot. Commit: a51e997 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42347 [ reuse-pipeline ] completed with state SUCCESS. Commit: a51e997
Reusing PR_Github #42313 (Partly Tested) for commit a51e997

Link to invocation

@jieli-matrix jieli-matrix merged commit 968a2d1 into NVIDIA:main Apr 9, 2026
7 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20260405_LLM_FUNCTION_TEST_2034 branch April 9, 2026 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants