Skip to content

[TRTLLM-12500][feat] Add support for Qwen3.5 VL MoE (with the MTP fixes)#14599

Open
moraxu wants to merge 6 commits into
NVIDIA:mainfrom
moraxu:dev-mguzek-qwen3_5-moe-vl-v2
Open

[TRTLLM-12500][feat] Add support for Qwen3.5 VL MoE (with the MTP fixes)#14599
moraxu wants to merge 6 commits into
NVIDIA:mainfrom
moraxu:dev-mguzek-qwen3_5-moe-vl-v2

Conversation

@moraxu

@moraxu moraxu commented May 26, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

Release Notes

  • New Features

    • Added support for Qwen3.5 Mixture-of-Experts multimodal vision-language model (Qwen3.5-35B-A3B).
    • Extended speculative decoding to support vision-language model workflows.
    • Added FP8 block-scales quantization support for the new model.
  • Documentation

    • Updated feature support matrix to include Qwen3.5-MoE multimodal model capabilities.
  • Tests

    • Added accuracy validation tests for Qwen3.5-MoE multimodal model on standard benchmarks.
    • Added configuration and forward-parity verification tests.

Description

  • Completes Qwen3.5-MoE-VL (Qwen3_5MoeForConditionalGeneration) on top of #12611.
  • Switches the VLM config path to HF's native transformers.Qwen3_5MoeConfig (present in 5.3.0), adds a thin post-load normalizer that materializes the handful of aliases the reused Qwen3Next runtime expects on text_config (intermediate_size from the MoE fields, rope_theta/partial_rotary_factor/rope_scaling from rope_parameters), and centralizes hybrid-cache dtype resolution in two helpers.
  • 284291a: Makes Qwen3VLModelBase MTP/eagle-compatible: threads spec_metadata / resource_manager / pre-fusion orig_input_ids to the inner LM. Unblocks TestQwen3_5_35B_A3B::test_bf16_mtp[mtp_on], which started failing after [TRTLLM-11547][feat] Add Qwen3.5 MTP support. #12646 added the MTP test on top of the original [TRTLLM-12500][feat] Add support for Qwen3.5 VL MoE - REVERTED by #14599 #14164 and the same Qwen3.5-35B-A3B checkpoint started routing through the VLM wrapper - see nvbugs/6206179 for details
  • Commits specific to this PR follow after the first two commits

Test Coverage

Accuracy & unit tests

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@moraxu

moraxu commented May 26, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50402 [ run ] triggered by Bot. Commit: 284291a Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50402 [ run ] completed with state SUCCESS. Commit: 284291a
/LLM/main/L0_MergeRequest_PR pipeline #39926 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@moraxu

moraxu commented May 27, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50459 [ run ] triggered by Bot. Commit: 284291a Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50459 [ run ] completed with state SUCCESS. Commit: 284291a
/LLM/main/L0_MergeRequest_PR pipeline #39975 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@moraxu

moraxu commented May 27, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50590 [ run ] triggered by Bot. Commit: 17c7a00 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50590 [ run ] completed with state FAILURE. Commit: 17c7a00
/LLM/main/L0_MergeRequest_PR pipeline #40088 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@moraxu

moraxu commented May 27, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50604 [ run ] triggered by Bot. Commit: 17c7a00 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50604 [ run ] completed with state FAILURE. Commit: 17c7a00
/LLM/main/L0_MergeRequest_PR pipeline #40099 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@tburt-nv

Copy link
Copy Markdown
Collaborator

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50613 [ run ] triggered by Bot. Commit: 17c7a00 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50613 [ run ] completed with state SUCCESS. Commit: 17c7a00
/LLM/main/L0_MergeRequest_PR pipeline #40108 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@moraxu

moraxu commented May 28, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50720 [ run ] triggered by Bot. Commit: 17c7a00 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50720 [ run ] completed with state SUCCESS. Commit: 17c7a00
/LLM/main/L0_MergeRequest_PR pipeline #40202 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@moraxu

moraxu commented May 28, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50739 [ run ] triggered by Bot. Commit: 17c7a00 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50739 [ run ] completed with state FAILURE. Commit: 17c7a00
/LLM/main/L0_MergeRequest_PR pipeline #40219 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@moraxu

moraxu commented May 28, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50834 [ run ] triggered by Bot. Commit: 17c7a00 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50834 [ run ] completed with state FAILURE. Commit: 17c7a00
/LLM/main/L0_MergeRequest_PR pipeline #40303 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@moraxu

moraxu commented May 28, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50866 [ run ] triggered by Bot. Commit: 17c7a00 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #50866 [ run ] completed with state FAILURE. Commit: 17c7a00
/LLM/main/L0_MergeRequest_PR pipeline #40332 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@moraxu

moraxu commented May 28, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@moraxu

moraxu commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #53962 [ run ] triggered by Bot. Commit: e3e87d2 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #53962 [ run ] completed with state FAILURE. Commit: e3e87d2
/LLM/main/L0_MergeRequest_PR pipeline #43053 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@2ez4bz

2ez4bz commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

/bot run

@venkywonka venkywonka left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm from doc-owners

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55103 [ run ] triggered by Bot. Commit: 260144a Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55103 [ run ] completed with state FAILURE. Commit: 260144a
/LLM/main/L0_MergeRequest_PR pipeline #44089 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@moraxu

moraxu commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55170 [ run ] triggered by Bot. Commit: 260144a Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55170 [ run ] completed with state SUCCESS. Commit: 260144a
/LLM/main/L0_MergeRequest_PR pipeline #44141 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@moraxu

moraxu commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55537 [ run ] triggered by Bot. Commit: 260144a Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55537 [ run ] completed with state SUCCESS. Commit: 260144a
/LLM/main/L0_MergeRequest_PR pipeline #44465 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@tburt-nv

Copy link
Copy Markdown
Collaborator

please rebase or merge origin/main to resolve the GB200-4_GPUs-PyTorch-PerfSanity-* failures with 91dc145

moraxu added 6 commits June 24, 2026 14:27
Signed-off-by: Michal Guzek <mguzek@nvidia.com>
Signed-off-by: Michal Guzek <mguzek@nvidia.com>
Signed-off-by: Michal Guzek <mguzek@nvidia.com>
Signed-off-by: Michal Guzek <mguzek@nvidia.com>
Signed-off-by: Michal Guzek <mguzek@nvidia.com>
Signed-off-by: Michal Guzek <mguzek@nvidia.com>
@moraxu moraxu force-pushed the dev-mguzek-qwen3_5-moe-vl-v2 branch from 260144a to 4035427 Compare June 25, 2026 00:00
@moraxu

moraxu commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55617 [ run ] triggered by Bot. Commit: 4035427 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55617 [ run ] completed with state FAILURE. Commit: 4035427
/LLM/main/L0_MergeRequest_PR pipeline #44534 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@moraxu

moraxu commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55701 [ run ] triggered by Bot. Commit: 4035427 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55701 [ run ] completed with state FAILURE. Commit: 4035427
/LLM/main/L0_MergeRequest_PR pipeline #44604 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@moraxu

moraxu commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55742 [ run ] triggered by Bot. Commit: 4035427 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55742 [ run ] completed with state SUCCESS. Commit: 4035427
/LLM/main/L0_MergeRequest_PR pipeline #44644 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants