Skip to content

[https://nvbugs/6290965][fix] Rename model_configpipeline_config on the two Cosmos3 test asserts and…#15263

Closed
tensorrt-cicd wants to merge 1 commit into
NVIDIA:mainfrom
tensorrt-cicd:repair-bot-bug6290965
Closed

[https://nvbugs/6290965][fix] Rename model_configpipeline_config on the two Cosmos3 test asserts and…#15263
tensorrt-cicd wants to merge 1 commit into
NVIDIA:mainfrom
tensorrt-cicd:repair-bot-bug6290965

Conversation

@tensorrt-cicd

@tensorrt-cicd tensorrt-cicd commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

Test plan

  • Verify fix on the same GPU type as the original failure
  • Check for regressions in related tests

Links

Summary by CodeRabbit

Release Notes

  • Tests
    • Removed test waivers for Cosmos3 pipeline validation tests
    • Updated quantization validation assertions to check configuration from updated source locations

…ne_config in Cosmos3 tests

Signed-off-by: tensorrt-cicd <90828364+tensorrt-cicd@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9948a25b-f2a5-42df-bbab-eb6c2eb28141

📥 Commits

Reviewing files that changed from the base of the PR and between 835fd61 and 52886e3.

📒 Files selected for processing (3)
  • tests/integration/test_lists/waives.txt
  • tests/unittest/_torch/visual_gen/test_cosmos3_pipeline.py
  • tests/unittest/_torch/visual_gen/test_cosmos3_transformer.py
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

This PR updates FP8 quantization assertion paths in Cosmos3 tests from pipeline.model_config.quant_config.quant_algo to pipeline.pipeline_config.quant_config.quant_algo, and removes corresponding test waivers that are no longer needed.

Changes

Cosmos3 FP8 Assertion and Test Waivers

Layer / File(s) Summary
FP8 quantization assertion path updates
tests/unittest/_torch/visual_gen/test_cosmos3_pipeline.py, tests/unittest/_torch/visual_gen/test_cosmos3_transformer.py, tests/integration/test_lists/waives.txt
FP8 assertions in TestCosmos3FP8Load.test_fp8_load_and_t2v and TestCosmos3TransformerCheckpoint.test_load_fp8_quantization now read quant_algo from pipeline.pipeline_config.quant_config instead of pipeline.model_config.quant_config. Corresponding test waivers for DGX_B200 Cosmos3 pipeline and transformer tests are removed from the skip list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#15195: Both PRs touch the same Cosmos3 B200 visual_gen FP8/transformer test coverage by updating tests/integration/test_lists/waives.txt for those specific tests.
  • NVIDIA/TensorRT-LLM#15061: Both PRs modify tests/integration/test_lists/waives.txt by removing/changing waiver entries for Cosmos3 pipeline-related tests.

Suggested reviewers

  • mzweilz
  • StanleySun639
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: renaming model_config to pipeline_config in Cosmos3 test files and removing stale waivers.
Description check ✅ Passed The description includes root cause, fix details, test plan, and relevant bug link, aligning well with the template requirements and providing clear context.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@bobboli

bobboli commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Duplicated #15170.

@bobboli bobboli closed this Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants