[None][fix] Pass dtype to AllReduce ctor to enable MNNVL all-reduce fo…#15547
Open
nv-guomingz wants to merge 1 commit into
Open
[None][fix] Pass dtype to AllReduce ctor to enable MNNVL all-reduce fo…#15547nv-guomingz wants to merge 1 commit into
nv-guomingz wants to merge 1 commit into
Conversation
…r Qwen3.5 Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
Collaborator
Author
|
/bot run --disable-fail-fast |
Contributor
📝 WalkthroughWalkthroughIn ChangesAllReduce dtype propagation in Qwen3Next
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Collaborator
|
PR_Github #55247 [ run ] triggered by Bot. Commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…r Qwen3.5
On NVL multi-node systems, AllReduce must be given dtype at construction so it can build the MNNVL all-reduce path (its Lamport workspace is sized by the dtype's element size). If dtype is omitted, mnnvl_allreduce is None, so the op falls back to the generic NCCL all-reduce across nodes — functionally correct but lower performance than the NVLink-fabric MNNVL path.