Skip to content

[None][infra] split single-node perf sanity GB200#15548

Merged
tburt-nv merged 1 commit into
mainfrom
user/tburt/perfsan
Jun 23, 2026
Merged

[None][infra] split single-node perf sanity GB200#15548
tburt-nv merged 1 commit into
mainfrom
user/tburt/perfsan

Conversation

@tburt-nv

@tburt-nv tburt-nv commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Description

Some perf-sanity stages are single-node and can be safely split. This is a follow-up to #14597.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Summary by CodeRabbit

  • Chores
    • Updated platform selector configuration for GB200 PerfSanity tests to use split configuration format instead of standard format across both pre-merge and post-merge test entries.

Signed-off-by: Tyler Burt <195370667+tburt-nv@users.noreply.github.com>
@tburt-nv tburt-nv requested review from a team as code owners June 23, 2026 15:48
@tburt-nv tburt-nv requested review from niukuo and yuanjingx87 June 23, 2026 15:48
@tburt-nv

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "can't make it worse"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55261 Bot args parsing error: Failed to parse bot args

Link to invocation

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ac9f7d00-aa48-48fc-9d32-5e08e1d1cee4

📥 Commits

Reviewing files that changed from the base of the PR and between beb922f and d134fce.

📒 Files selected for processing (1)
  • jenkins/L0_Test.groovy

📝 Walkthrough

Walkthrough

In jenkins/L0_Test.groovy, the platform selector for GB200 PerfSanity SBSA SLURM stage configurations is changed from auto:gb200-x4 to auto:gb200-x4-split for both pre-merge (PerfSanity-1) and post-merge (PerfSanity-Post-Merge-1..9) entries in the SBSASlurmTestConfigs map.

GB200 PerfSanity Platform Selector Update

Layer / File(s) Summary
GB200 PerfSanity SLURM platform selector
jenkins/L0_Test.groovy
Platform selector string updated from auto:gb200-x4 to auto:gb200-x4-split for all pre-merge and post-merge GB200 PerfSanity stage entries in SBSASlurmTestConfigs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: splitting single-node perf sanity GB200 tests, with proper [None][infra] tag indicating this is an infrastructure change.
Description check ✅ Passed The description adequately explains the purpose (splitting single-node perf-sanity stages), references the related PR #14597, and includes a completed PR checklist appropriate for an infrastructure change with no API modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch user/tburt/perfsan

Comment @coderabbitai help to get the list of available commands.

@ixlmar

ixlmar commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

/bot skip --comment "cannot make it worse"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55262 [ skip ] triggered by Bot. Commit: d134fce Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55262 [ skip ] completed with state SUCCESS. Commit: d134fce
Skipping testing for commit d134fce

Link to invocation

@tburt-nv tburt-nv merged commit 91dc145 into main Jun 23, 2026
17 of 18 checks passed
@tburt-nv tburt-nv deleted the user/tburt/perfsan branch June 23, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants