-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[https://nvbugs/6020038][feat] Add NCCL-EP v0.1 MoE communication support #15597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nv-lschneider
wants to merge
7
commits into
NVIDIA:main
Choose a base branch
from
nv-lschneider:tekit-mr-10228-squashed
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7d4f5d6
[NVBUG-6020038][feat] Use nccl4py for NCCL EP integration
nv-lschneider 84edc8c
[NVBUG-6020038][chore] Address CodeRabbit NCCL-EP review feedback
nv-lschneider 624395c
[NVBUG-6020038][fix] fix NCCL EP teardown and folded weights
nv-lschneider a891832
Allow NCCL EP without explicit MoE token cap
nv-lschneider 6a1a93d
Lazy initialize NCCL EP context
nv-lschneider 229d6b8
Guard NCCL EP lazy init during graph capture
nv-lschneider 098d66b
Handle NCCL EP probe runtime failures
nv-lschneider File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's confirm the expected way of pinning NCCL version with @EmmaQiaoCh. This adds
nccl4py, but the same requirements file still pinsnvidia-nccl-cu13<=2.29.2, whileis_nccl_ep_installed()requires the loadedlibnccl.so>=2.30.4. @EmmaQiaoCh not sure if we are pinning NCCL version in the container image, or via pipnvidia-nccl-cu13?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that is a known limitation today.
That is why this PR is marked as draft.
PR #15087 will update to NCCL 2.30.4 (via pip requirements.txt)
I will schedule a meeting soon about the inclusion of nccl4py