Skip to content

[https://nvbugs/6248783][test] Unwaive Qwen3 skip softmax test#15652

Merged
bobboli merged 1 commit into
NVIDIA:mainfrom
bobboli:unwaive-6248783
Jun 26, 2026
Merged

[https://nvbugs/6248783][test] Unwaive Qwen3 skip softmax test#15652
bobboli merged 1 commit into
NVIDIA:mainfrom
bobboli:unwaive-6248783

Conversation

@bobboli

@bobboli bobboli commented Jun 26, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Description

Remove the waiver for the Qwen3 skip softmax attention 4-GPU test associated with https://nvbugs/6248783.

Testing

  • git diff --check
  • pre-commit hooks from git commit, including waiver duplicate checks and test-list entry validation

Summary by CodeRabbit

  • Tests
    • Removed an outdated test waiver, so the affected check now runs normally again.

@bobboli
[https://nvbugs/6248783][test] Unwaive Qwen3 skip softmax test
cc98094 
Signed-off-by: Bo Li <22713281+bobboli@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5db8f410-8854-4662-8119-5b1f24852fba

📥 Commits

Reviewing files that changed from the base of the PR and between 0425801 and cc98094.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt
📝 Walkthrough

Walkthrough

Removed one SKIP waiver entry for a specific parametrized integration test, so that case is no longer excluded through the waiver list.

Changes

Integration waiver update

Layer / File(s) Summary
Remove one SKIP waiver
tests/integration/test_lists/waives.txt		 Removes the waiver entry for accuracy/test_llm_api_pytorch.py::TestQwen3_30B_A3B_Instruct_2507::test_skip_softmax_attention_4gpus[target_sparsity_0.5-fp8kv=True].

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • jieli-matrix
  • crazydemo
  • StanleySun639
  • xinhe-nv
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change and testing, but it omits required template sections like Test Coverage and the PR Checklist. Add the template sections, especially a Test Coverage section and the PR Checklist, and keep the description aligned with the repository format.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise, specific, and accurately reflects the waiver removal for the Qwen3 skip softmax test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@bobboli

bobboli commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --post-merge

@tensorrt-cicd

tensorrt-cicd commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

PR_Github #55998 [ run ] triggered by Bot. Commit: cc98094 Link to invocation

@tensorrt-cicd

tensorrt-cicd commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

PR_Github #55998 [ run ] completed with state SUCCESS. Commit: cc98094
/LLM/main/L0_MergeRequest_PR pipeline #44872 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@bobboli bobboli enabled auto-merge (squash) June 26, 2026 09:59
@bobboli

bobboli commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --reuse-test --post-merge

@tensorrt-cicd

tensorrt-cicd commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

PR_Github #56063 [ run ] triggered by Bot. Commit: cc98094 Link to invocation

@tensorrt-cicd

tensorrt-cicd commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

PR_Github #56063 [ run ] completed with state SUCCESS. Commit: cc98094
/LLM/main/L0_MergeRequest_PR pipeline #44931 completed with status: 'SUCCESS'

CI Report

Link to invocation

@bobboli bobboli requested review from LarryXFly, ZhanruiSunCh and jieli-matrix and removed request for ZhanruiSunCh June 26, 2026 13:44
@bobboli bobboli merged commit 4164b93 into NVIDIA:main Jun 26, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crazydemo crazydemo crazydemo approved these changes
@jieli-matrix jieli-matrix Awaiting requested review from jieli-matrix
@ZhanruiSunCh ZhanruiSunCh Awaiting requested review from ZhanruiSunCh
@LarryXFly LarryXFly Awaiting requested review from LarryXFly

Assignees

@bobboli bobboli

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bobboli @tensorrt-cicd @crazydemo