Skip to content

[None][chore] replace mktemp #15725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tburt-nv wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[None][chore] replace mktemp #15725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cb5316
add unittest/others/test_builder back to post-merge
tburt-nv Jun 29, 2026
e77db5e
replace mktemp
tburt-nv Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/integration/test_lists/test-db/l0_a10.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,7 @@ l0_a10:
- llmapi/test_llm_examples.py::test_llmapi_quickstart_atexit
- unittest/test_model_runner_cpp.py
- unittest/llmapi/test_build_cache.py
- unittest/others/test_builder.py
- unittest/trt/attention/test_gpt_attention_IFB.py
- unittest/trt/attention/test_gpt_attention_no_cache.py
- condition:
Expand Down
4 changes: 3 additions & 1 deletion tests/unittest/others/test_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@ def test_basic_builder_flow(self):
assert engine is not None
refit_engine = builder.refit_engine(network, engine)
assert refit_engine is not None
builder.save_config(builder_config, tempfile.mktemp())
with tempfile.TemporaryDirectory() as tmpdir:
config_path = f"{tmpdir}/builder_config.json"
builder.save_config(builder_config, config_path)

def test_top_level_dont_have_functional_apis(self):
# This did not check all the functional apis, but should already prevent
Expand Down
Loading