[TRTLLM-12728][feat] Add WideEP FT E2E MVP integration prototype (DO NOT REVIEW)#15801
Draft
chienchunhung wants to merge 14 commits into
Draft
[TRTLLM-12728][feat] Add WideEP FT E2E MVP integration prototype (DO NOT REVIEW)#15801chienchunhung wants to merge 14 commits into
chienchunhung wants to merge 14 commits into
Conversation
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Status: DRAFT — integration prototype, not ready to merge
This PR is the production-component integration branch for the WideEP fault-tolerance MVP. It replaces the stub-heavy seam-finding role of #14198 with a branch composed from the real implementation PRs, so we can exercise cross-component behavior on physical hardware and use the result to guide the remaining PRs and their reviews.
This draft does not yet claim an end-to-end recovery success or MVP completion. The missing vertical slices and physical acceptance gates are listed below.
Description
The branch stacks the current WideEP FT implementation units on
main:The integration contract is intentionally strict:
detect → abort failed epoch → reconcile evidence → validate admission → quiesce → prepare EPLB → rebuild survivor control/NCCL → apply graph policy → commit mask + ActiveRankMap + generation → apply request disposition → resumeDetection is evidence, not authorization to mutate the data-plane mask. No output from the failed execution epoch may escape.
Remaining work before this becomes an E2E working MVP
ActiveRankMap, and survivor-aware attention-DP/PyExecutor collectives.Until these land, unsupported routes and physical failure classes must fail closed rather than return partial or zero-filled logits.
Review guidance
Canonical design and execution tracking:
Test Coverage
Pre-publication integration checks:
git diff --check upstream/main...HEADpasses.upstream/mainin a merge-tree check.Not yet run on this aggregate branch:
PR Checklist
Please review the following before submitting this PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions).
If PR introduces API changes, an appropriate PR label is added—either
api-compatibleorapi-breaking.Any new dependencies have been scanned for license and vulnerabilities.
CODEOWNERS is updated if ownership changes.
Documentation is updated as needed.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, comment
/bot help.