Skip to content

[https://nvbugs/6411931][fix] Append ,fo to the ignore-words-list in pyproject.toml… #15924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trtllm-agent wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

[https://nvbugs/6411931][fix] Append ,fo to the ignore-words-list in pyproject.toml… #15924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ column_limit = 80

[tool.codespell]
skip = ".git,3rdparty,triton_kernels,tests/integration/test_input_files**,**.jsonl,**.json"
ignore-words-list = "rouge,inout,atleast,strat,nd,subtile,thrid,improbe,NotIn,te,iteract,anythin,tru,Tracin,vEw,dOut,indext,asend,medias"
ignore-words-list = "rouge,inout,atleast,strat,nd,subtile,thrid,improbe,NotIn,te,iteract,anythin,tru,Tracin,vEw,dOut,indext,asend,medias,fo"

@coderabbitai coderabbitai Bot Jul 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '\n== pyproject.toml codespell section ==\n'
rg -n -A3 -B3 '^\[tool\.codespell\]|ignore-words-list|codespell' pyproject.toml || true

printf '\n== .pre-commit-config.yaml codespell hook ==\n'
rg -n -A8 -B3 'codespell|-\s*L|ignore-words|pyproject' .pre-commit-config.yaml || true

printf '\n== other codespell config references ==\n'
rg -n 'ignore-words-list|codespell.*pyproject|--config.*pyproject|codespell' -g '!*.git' .

Repository: NVIDIA/TensorRT-LLM

Length of output: 2315

🌐 Web query:

codespell pyproject.toml configuration pre-commit --ignore-words-list command line -L does codespell read pyproject automatically

💡 Result:

Yes, codespell automatically detects and reads a pyproject.toml file if it is located in the current working directory [1][2]. Configuration To use pyproject.toml, place your settings under the [tool.codespell] section [1][2]. For the ignore-words-list option, specify a comma-separated string of words [3]. For example: [tool.codespell] ignore-words-list = "word1,word2,word3" Prerequisites For this functionality to work, the tomli library must be available [1][2]. - Python 3.11 and later includes tomli support in the standard library, so no extra setup is required [4]. - For Python versions prior to 3.11, you must install the tomli package [1][2]. Pre-commit When using codespell with pre-commit, you must ensure that tomli is available to the hook's environment [4]. You can do this by adding it to the additional_dependencies list in your.pre-commit-config.yaml [3][4]: - repo: https://github.com/codespell-project/codespell rev: v2.4.2 hooks: - id: codespell additional_dependencies: - tomli If your configuration is not being picked up, confirm that the file is in the root directory (where the codespell command is executed) or specify the path explicitly using the --toml command-line argument [1][2]. Note that command-line arguments will override settings found in configuration files [1][2].

Citations:

🌐 Web query:

codespell command line -L overrides pyproject ignore-words-list precedence merge behavior

💡 Result:

When using codespell, options provided via the command line, including the -L (or --ignore-words-list) flag, override any corresponding settings defined in a pyproject.toml configuration file [1][2][3]. Codespell does not merge the ignore-words-list from the command line with those defined in your configuration file; instead, the command line argument completely replaces the configuration file's value [1][4]. If you specify -L on the command line, only the words provided in that argument will be ignored by codespell during that execution, effectively ignoring any additional words you may have configured in pyproject.toml [1][4]. To ensure both sets of words are ignored, you must manually include all desired words in the command line argument, or rely solely on a configuration file if you prefer a persistent, unified list [1][3]. Configuration files are read in a specific order (with pyproject.toml typically checked first), and while multiple config files can be processed, command line arguments act as the final authority that overrides all config-based settings [1][4].

Citations:

🌐 Web query:

codespell -L ignore words list with pyproject.toml precedence documentation

💡 Result:

To configure codespell with an ignore words list in a pyproject.toml file, use the [tool.codespell] section with the ignore-words-list key [1][2]. The value must be a string containing a comma-separated list of words [3][4]. Example configuration: [tool.codespell] ignore-words-list = "word1,word2,word3" Regarding precedence and configuration: 1. Precedence: Options specified on the command line override those defined in configuration files [1][2][5]. If multiple configuration files are present, they are read in a specific order, and the most recently read file overwrites previously specified configurations [1][2]. 2. Configuration Order: Codespell checks for configuration files in the following order [1][5]: - pyproject.toml (requires the tomli package for Python versions prior to 3.11) [1][6] - setup.cfg -.codespellrc - Any additional file explicitly supplied via the --config command line argument [1][5]. 3. Implementation Note: Because codespell maps configuration file entries to command line arguments, ensure your ignore words are lowercase if they are meant to match lowercase dictionary entries [3][4]. For boolean flags in pyproject.toml (e.g., check-hidden), setting the value to an empty string (e.g., check-hidden = "") is often the standard way to toggle them on [3][7].

Citations:

🌐 Web query:

codespell README -L option pyproject.toml ignore-words-list precedence combine

💡 Result:

In codespell, the ignore-words-list option is used to define a comma-separated list of words to be ignored [1][2][3]. When configuring this via pyproject.toml, you must provide the list as a string within the [tool.codespell] section [1][4][5]. Configuration Example: [tool.codespell] ignore-words-list = "word1,word2,word3" Regarding precedence and usage: 1. Precedence: Options specified directly on the command line will always override options defined in configuration files (such as pyproject.toml, setup.cfg, or .codespellrc) [4][5][3]. 2. Case Sensitivity: The ignore-words-list is case-sensitive and must match the word exactly as it appears in the codespell dictionary file [1][6]. If a word is not being ignored as expected, ensure it is written in lowercase (or the exact casing required by the dictionary) [1][6][7]. 3. Configuration Files: Codespell reads multiple configuration files if present, with the most recently read file overwriting previous settings [4][5][3]. The standard search order for configuration files includes pyproject.toml, setup.cfg, and .codespellrc [4][5]. For command-line usage, the -L flag is equivalent to --ignore-words-list [2][3][8]. If you need to ignore many words, using a separate file with the -I (or --ignore-words) option may be preferable [4][5][3].

Citations:

Add fo to the codespell hook too. .pre-commit-config.yaml hard-codes its own -L list, so the new pyproject.toml entry is ignored by pre-commit/CI.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@pyproject.toml` at line 22, The new `fo` exception is only added in
`pyproject.toml`, but the codespell pre-commit setup still uses its own
hard-coded ignore list, so the CI hook will keep flagging it. Update the
codespell configuration in `.pre-commit-config.yaml` to include `fo` in the `-L`
list, keeping it aligned with the `ignore-words-list` entry in `pyproject.toml`.


[tool.autoflake]
in-place = true
Expand Down
Loading