[None][test] Fix MLA import path in attention perf harness#16179
Conversation
The DSA builder imported MLA from tensorrt_llm._torch.modules.attention, but the MLA class lives in tensorrt_llm._torch.modules.mla. This made test_dsa_ctx_dispatch fail at collection with ImportError against any wheel. Import MLA from its real module. Signed-off-by: Ruodi Lu <200874449+ruodil@users.noreply.github.com>
|
/bot skip --comment "skip test as just modifying cases" |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe DSA MLA module builder in the attention performance test harness now imports the MLA class from tensorrt_llm._torch.modules.mla instead of tensorrt_llm._torch.modules.attention. This is a single-line import source change with no other logic modifications. ChangesImport correction
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #58401 [ skip ] triggered by Bot. Commit: |
|
PR_Github #58401 [ skip ] completed with state |
The DSA builder imported MLA from tensorrt_llm._torch.modules.attention, but the MLA class lives in tensorrt_llm._torch.modules.mla. This made test_dsa_ctx_dispatch fail at collection with ImportError against any wheel. Import MLA from its real module.
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.