Skip to content

[Common][PyTorch] EP dispatch with unfused MXFP8 quantization - #3270

Open
phu0ngng wants to merge 4 commits into
NVIDIA:mainfrom
phu0ngng:ep_mxfp8
Open

[Common][PyTorch] EP dispatch with unfused MXFP8 quantization#3270
phu0ngng wants to merge 4 commits into
NVIDIA:mainfrom
phu0ngng:ep_mxfp8

Conversation

@phu0ngng

Copy link
Copy Markdown
Collaborator

Description

This PR adds MXFP8 support to the dispatch op of the NCCL EP path. The dispatch op is used in two places, and MXFP8 applies to both:

  • Dispatch forward bfloat16 tokens are quantized to MXFP8 internally and dispatched to the target experts; recv is returned as a per-expert GroupedTensor.
  • Combine backward the result-grad is scattered back to expert positions through the same (reverse) dispatch op, quantized to MXFP8, returning the expert-output grad as a per-expert GroupedTensor.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

PyTorch frontend (transformer_engine/pytorch/ep.py, distributed.py, csrc/extensions/ep.cpp)**

  • The dispatch op quantizes bfloat16 tokens to MXFP8 internally when the buffer's dispatch_quant_recipe is set (MXFP8BlockScaling only for now); dispatch-forward recv is returned as a per-expert GroupedTensor. A pre-quantized input is rejected.
  • Combine backward reuses the dispatch op to scatter the result-grad: it quantizes the grad to MXFP8 and returns the expert-output grad as a per-expert GroupedTensor. Combine forward is unchanged (high-precision).
  • Recv data and block scales share a single caller-supplied (optionally symm-mem-backed) buffer, sliced into data-then-scale regions; the same convention is used for the combine backward grad buffer.

Common backend (common/ep/ep_backend.cpp, include/.../ep.h, comm_window.h)**

  • Backend and public headers extended to carry block-scale buffers/windows through the dispatch primitive.

NCCL EP submodule**

  • Bumped 3rdparty/nccl-extensions to the revision providing block-scaled dispatch.

Tests (tests/cpp_distributed/test_ep.cu, tests/pytorch/distributed/run_ep.py, run_test_ep.sh)**

  • Added C++ distributed coverage for the MXFP8 dispatch path.
  • Added PyTorch MXFP8 test passes for dispatch forward (normal, zero-copy, eager IO modes) and combine backward, gated behind a dedicated NVTE_EP_MXFP8_PASS run since the grouped path pins the per-expert alignment process-wide.

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
@greptile-apps

greptile-apps Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds unfused MXFP8 quantization to NCCL expert-parallel dispatch and combine backward.

  • Routes MXFP8 data and block scales together through the common backend and PyTorch bindings.
  • Returns dispatched activations and combine-backward gradients as per-expert grouped tensors.
  • Adds symmetric-memory buffer slicing, pool teardown support, and distributed MXFP8 coverage.

Confidence Score: 4/5

The MXFP8 implementation appears safe to merge, with only the previously reported repository ignore-file deletion still requiring attention.

The EP data-and-scale paths are consistently represented across the Python frontend, binding layer, common backend, and distributed tests; however, the repository ignore configuration remains entirely deleted, leaving generated and local artifacts visible to Git.

Files Needing Attention: .gitignore

Important Files Changed

Filename Overview
transformer_engine/pytorch/ep.py Adds recipe-controlled MXFP8 quantization, shared data/scale output allocation, grouped-tensor construction, and quantized combine backward.
transformer_engine/pytorch/csrc/extensions/ep.cpp Extends PyTorch EP bindings to validate and forward compact MXFP8 scale-inverse tensors and symmetric-memory windows.
transformer_engine/common/ep/ep_backend.cpp Builds NCCL descriptors for block scales and enables scale-forwarding dispatch for MXFP8 payloads.
transformer_engine/pytorch/distributed.py Adds explicit teardown for the process-wide symmetric-memory pool and its cached NCCL-backed segments.
tests/pytorch/distributed/run_ep.py Adds dedicated distributed coverage for MXFP8 dispatch, caller-provided buffers, zero-copy behavior, eager mode, and combine backward.

Sequence Diagram

sequenceDiagram
  participant User
  participant EP as PyTorch EP
  participant Quant as MXFP8 Quantizer
  participant Bind as C++ Binding
  participant Backend as NCCL EP Backend
  User->>EP: ep_dispatch(bfloat16 tokens)
  EP->>Quant: Quantize to E4M3 + E8M0 scales
  Quant-->>EP: Data and compact scale-inverse
  EP->>Bind: Dispatch data and scales
  Bind->>Backend: Block-scaled dispatch
  Backend-->>EP: Expert-major data and scales
  EP-->>User: Per-expert GroupedTensor
  User->>EP: ep_combine(expert outputs)
  EP-->>User: High-precision combined result
  User->>EP: Backward(result gradient)
  EP->>Quant: Quantize result gradient
  EP->>Backend: Reverse dispatch data and scales
  Backend-->>User: Per-expert grouped output gradient
Loading

Reviews (3): Last reviewed commit: "Separate EP dispatch-forward and combine..." | Re-trigger Greptile

@phu0ngng
phu0ngng requested a review from zhongbozhu July 28, 2026 23:33
Comment thread transformer_engine/pytorch/ep.py Outdated
alignment: int = 0,
payload_dtype: torch.dtype = torch.bfloat16,
device: Optional[torch.device] = None,
dispatch_quant_recipe: Optional["Recipe"] = None,

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me separate the recipe for dispatch fwd and combine bwd, in case users want to use different quantization for fwd and bwd in the future.

phu0ngng added 2 commits July 30, 2026 10:29
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
@phu0ngng

Copy link
Copy Markdown
Collaborator Author

/te-ci L1 pytorch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant