object: add target-side CSV select MVP#326
Closed
Rohithmatham12 wants to merge 1 commit into
Closed
Conversation
alex-aizman
reviewed
Jul 8, 2026
| import ( | ||
| "fmt" | ||
| "io" | ||
| "net/http" |
Member
There was a problem hiding this comment.
- unacceptable heap allocation in the critical path
- matchSelectPredicate is called in the main loop (for each row) and parses the same user-given value - unacceptable as well
Member
|
Closing (comment inline) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ais object selectas a limited CSV MVP that routes through AIS instead of filtering locally in the CLI.select-objobject POST action; the proxy redirects to the owning target, and the target reads the source object viaLOM.GetROCand streams selected CSV rows.api.SelectObjectReaderfor callers that want the server-side object-select response stream.SELECTprojection,SELECT *, optionalFROM, and simple string/numericWHEREpredicates.Why
This replaces the closed client-side prototype in #310 with the server/target-side MVP requested in review. The CLI no longer performs a normal full-object GET and filters locally; it POSTs an object action to AIS, and the target performs the read/filter/stream path.
Scope / non-goals
Testing
GOCACHE=/private/tmp/aistore-select-gocache GOMODCACHE=/private/tmp/aistore-select-gomodcache go test ./cmnGOCACHE=/private/tmp/aistore-select-gocache GOMODCACHE=/private/tmp/aistore-select-gomodcache go test ./apiGOCACHE=/private/tmp/aistore-select-gocache GOMODCACHE=/private/tmp/aistore-select-gomodcache go test ./ais -run TestObjSelectRunsOnTargetcd cmd/cli && GOCACHE=/private/tmp/aistore-select-gocache GOMODCACHE=/private/tmp/aistore-select-gomodcache go test ./cligit diff --checkReplaces the closed client-side prototype #310.
Refs #305.