Commit 136be26
Mixtral recipe code review fixes: configs, style, test coverage
Address 20 issues from automated code review comparing Mixtral recipes
against established ESM2/Llama3 patterns:
- Fix Dockerfiles to use 26.03 base image (matching repo-wide update)
- Fix L0_sanity.yaml: EP=1 for single-GPU tests, offline WandB, generic names
- Remove 10 dev-only test_*.yaml configs with hardcoded paths
- Add inline comments to defaults.yaml matching Llama3 pattern
- Add section comments to training scripts (train_fsdp2.py, train_ddp.py)
- Fix OG2 unconditional FP8 recipe creation, f-string logging, dup license
- Expand test_train.py from 3 to 7 tests (DDP, HF baseline, FP8, grad-acc)
- Expand test_train_two_gpu.py from 1 to 4 tests (DDP, checkpoint, EP=2)
- Add test_dataset.py for mixtral_native_te (BSHD/THD dataloader tests)
- Add test_distributed_checkpointing.py for opengenome2_mixtral_native_te
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent 49e8426 commit 136be26
24 files changed
Lines changed: 657 additions & 497 deletions
File tree
- bionemo-recipes/recipes
- mixtral_native_te
- hydra_config
- tests
- opengenome2_mixtral_native_te
- hydra_config
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
Lines changed: 4 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
26 | | - | |
27 | | - | |
| 25 | + | |
| 26 | + | |
28 | 27 | | |
29 | 28 | | |
30 | 29 | | |
| |||
40 | 39 | | |
41 | 40 | | |
42 | 41 | | |
43 | | - | |
44 | | - | |
| 42 | + | |
| 43 | + | |
45 | 44 | | |
46 | 45 | | |
47 | 46 | | |
| |||
Lines changed: 18 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | | - | |
4 | | - | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
28 | | - | |
29 | | - | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
37 | 38 | | |
38 | 39 | | |
39 | | - | |
| 40 | + | |
40 | 41 | | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
41 | 45 | | |
42 | 46 | | |
43 | 47 | | |
| |||
50 | 54 | | |
51 | 55 | | |
52 | 56 | | |
| 57 | + | |
53 | 58 | | |
54 | 59 | | |
55 | 60 | | |
56 | 61 | | |
57 | 62 | | |
58 | 63 | | |
59 | 64 | | |
| 65 | + | |
60 | 66 | | |
61 | 67 | | |
62 | 68 | | |
63 | 69 | | |
64 | 70 | | |
| 71 | + | |
65 | 72 | | |
66 | 73 | | |
67 | 74 | | |
68 | 75 | | |
69 | 76 | | |
70 | | - | |
71 | | - | |
| 77 | + | |
| 78 | + | |
72 | 79 | | |
73 | 80 | | |
74 | 81 | | |
| |||
Lines changed: 0 additions & 47 deletions
This file was deleted.
Lines changed: 0 additions & 47 deletions
This file was deleted.
Lines changed: 0 additions & 47 deletions
This file was deleted.
Lines changed: 0 additions & 47 deletions
This file was deleted.
Lines changed: 0 additions & 47 deletions
This file was deleted.
Lines changed: 0 additions & 47 deletions
This file was deleted.
0 commit comments