Skip to content

Commit 53be421

Browse files
committed
skip multi-gpu mfsdp tests
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
1 parent 610c1c7 commit 53be421

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

models/esm2/tests/test_distributed_strategies.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
],
4141
)
4242
@pytest.mark.parametrize("backend", ["te", "eager"])
43-
def test_ddp_vs_fsdp2_single_gpu(strategy, backend):
43+
def test_ddp_vs_fsdp_single_gpu(strategy, backend):
4444
cmd = [
4545
"torchrun",
4646
"--nproc_per_node=1",
@@ -68,7 +68,13 @@ def test_ddp_vs_fsdp2_single_gpu(strategy, backend):
6868
@requires_multi_gpu
6969
@pytest.mark.parametrize("strategy", ["fsdp2", "mfsdp"])
7070
@pytest.mark.parametrize("backend", ["te", "eager"])
71-
def test_ddp_vs_fsdp2_multi_gpu(strategy, backend):
71+
def test_ddp_vs_fsdp_multi_gpu(strategy, backend):
72+
if strategy == "mfsdp":
73+
pytest.skip(
74+
"MFSDP multi-gpu tests are currently failing because tensors are not always evenly sharded, leaving p.grad "
75+
"to be None on some ranks (BIONEMO-2726)"
76+
)
77+
7278
cmd = [
7379
"torchrun",
7480
"--nproc_per_node=2",

0 commit comments

Comments
 (0)