Skip to content

Commit 5b3f386

Browse files
committed
Better name for test
Signed-off-by: John St John <jstjohn@nvidia.com>
1 parent 7a6d14a commit 5b3f386

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

sub-packages/bionemo-evo2/tests/bionemo/evo2/run/test_predict.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ def baseline_predictions_7b_1m_results(
257257
],
258258
ids=lambda x: f"ddp={x[0]},cp={x[1]},pp={x[2]},tp={x[3]},fp8={x[4]},wi={x[5]}",
259259
)
260-
def test_predict_evo2_runs_with_log_probs(
260+
def test_predict_evo2_equivalent_with_log_probs(
261261
tmp_path,
262262
ddp: int,
263263
cp: int,
@@ -276,6 +276,9 @@ def test_predict_evo2_runs_with_log_probs(
276276
The command is run in a subshell, and we assert that it returns an exit code of 0.
277277
278278
For this test, we want coverage of CP, so we make sure sequence lengths are all the same and divisible by CP.
279+
280+
The other thing this test does is check that the log probabilities are equivalent to the baseline predictions
281+
without model parallelism.
279282
"""
280283

281284
world_size = ddp * cp * pp * tp

0 commit comments

Comments
 (0)