Skip to content

Commit a1e2340

Browse files
authored
[BENCHMAKRS] fix jet evo2 pretrain for partial conv (#1115)
### Description Fixed installation of the subquadratic package in the command for Evo2 pretrain partial-convergence benchmarks <!-- Provide a detailed description of the changes in this PR --> ### Type of changes <!-- Mark the relevant option with an [x] --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Refactor - [ ] Documentation update - [ ] Other (please describe): ### CI Pipeline Configuration Configure CI behavior by applying the relevant labels: - [SKIP_CI](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#skip_ci) - Skip all continuous integration tests - [INCLUDE_NOTEBOOKS_TESTS](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#include_notebooks_tests) - Execute notebook validation tests in pytest - [INCLUDE_SLOW_TESTS](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#include_slow_tests) - Execute tests labelled as slow in pytest for extensive testing > [!NOTE] > By default, the notebooks validation tests are skipped unless explicitly enabled. #### Authorizing CI Runs We use [copy-pr-bot](https://docs.gha-runners.nvidia.com/apps/copy-pr-bot/#automation) to manage authorization of CI runs on NVIDIA's compute resources. - If a pull request is opened by a trusted user and contains only trusted changes, the pull request's code will automatically be copied to a pull-request/ prefixed branch in the source repository (e.g. pull-request/123) - If a pull request is opened by an untrusted user or contains untrusted changes, an NVIDIA org member must leave an `/ok to test` comment on the pull request to trigger CI. This will need to be done for each new commit. ### Usage <!--- How does a user interact with the changed code --> ```python # TODO: Add code snippet ``` ### Pre-submit Checklist <!--- Ensure all items are completed before submitting --> - [ ] I have tested these changes locally - [ ] I have updated the documentation accordingly - [ ] I have added/updated tests as needed - [ ] All existing tests pass successfully <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Renamed public configuration key from artefacts_url to pckg_url. Update any custom configs or scripts accordingly. * **Chores** * Updated package installation to use an authenticated index URL with a fallback to the public index for improved reliability. * Aligned default URL format to match the new pckg_url key. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent bc468a7 commit a1e2340

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

ci/benchmarks/partial-conv/evo2_pretrain.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,15 @@ key_segments:
77
lr: False
88
min_lr: False
99
wu_steps: False
10-
artefacts_url: False
10+
pckg_url: False
1111
file_name_wheel: False
1212
script_args:
1313
# All arguments referenced in the script string must be specified here.
1414
# Arguments not referenced in the script string must have the 'arg' field specified.
1515
# See jet/core/configs.py for the specification of the configuration class
1616
workspace: /workspace/bionemo2
1717
data_path: /data/evo2
18-
artefacts_url: https://__token__:${{JET_GITLAB_TOKEN}}@gitlab-master.nvidia.com/api/v4/projects/180496/packages/pypi/simple
18+
pckg_url: gitlab-master.nvidia.com/api/v4/projects/180496/packages/pypi/simple/
1919
file_name_wheel: subquadratic-ops
2020
model: evo2
2121
variant: train
@@ -40,7 +40,7 @@ script_args:
4040
script: |-
4141
INSTALL_FLAG="/tmp/install_done_${{SLURMD_NODENAME}}";
4242
if [ "$SLURM_LOCALID" = "0" ]; then
43-
pip install ${file_name_wheel} --index-url ${artefacts_url}
43+
pip install ${file_name_wheel} --index-url https://oauth2:$JET_GITLAB_TOKEN@${pckg_url} --extra-index-url https://pypi.org/simple/
4444
touch $INSTALL_FLAG
4545
fi
4646
# All ranks wait until install flag file appears

0 commit comments

Comments
 (0)