Skip to content

Commit e80f6f4

Browse files
committed
Add TODO for supporting other kinds of parallelism
Signed-off-by: John St John <jstjohn@nvidia.com>
1 parent 4dec162 commit e80f6f4

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

sub-packages/bionemo-llm/src/bionemo/llm/utils/callbacks.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,8 @@ def data_parallel_rank(self) -> int:
8989
@property
9090
def should_write_predictions(self) -> bool:
9191
"""Returns the context parallel rank."""
92+
93+
# TODO: handle expert parallelism and other kinds of parallelism
9294
return self.save_all_model_parallel_ranks or (
9395
parallel_state.is_pipeline_last_stage()
9496
and parallel_state.get_tensor_model_parallel_rank() == 0

0 commit comments

Comments
 (0)