Bump NeMo to use a trunk commit instead of a branch for Evo2 fixes and inference.#861
Merged
Conversation
…d inference. Signed-off-by: Cory Ye <cye@nvidia.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #861 +/- ##
==========================================
+ Coverage 84.38% 84.41% +0.03%
==========================================
Files 138 138
Lines 8691 8695 +4
==========================================
+ Hits 7334 7340 +6
+ Misses 1357 1355 -2
|
0fcd3a9 to
91fb3b5
Compare
skothenhill-nv
approved these changes
May 7, 2025
Signed-off-by: Cory Ye <cye@nvidia.com>
91fb3b5 to
2db0330
Compare
camirr-nv
pushed a commit
that referenced
this pull request
Jun 26, 2025
…d inference. (#861) ### Description <!-- Provide a detailed description of the changes in this PR --> - #798 (#855) depends on a NeMo branch, which has been merged into NeMo `main`: NVIDIA-NeMo/NeMo#13436. Update to point to this trunk commit. ### Details - NeMo ToT reverted the `cp_size` argument for `masked_token_loss` (NVIDIA-NeMo/NeMo#13295), so we do the CP reduction on our side now... - Future Megatron bump will add the `* cp_size` multiplier to the loss, and break our inference unit tests due to `torch.inference_mode()` usage in Megatron. --------- Signed-off-by: Cory Ye <cye@nvidia.com> Signed-off-by: Ubuntu <camirr@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
main: Migrate Hyena to Megatron inference_context. NVIDIA-NeMo/NeMo#13436. Update to point to this trunk commit.Details
cp_sizeargument formasked_token_loss(Fix loss compute and reduction NVIDIA-NeMo/NeMo#13295), so we do the CP reduction on our side now...* cp_sizemultiplier to the loss, and break our inference unit tests due totorch.inference_mode()usage in Megatron.