modernize-use-equals-default

Author: Jacobfaib

.clang-tidy

@@ -26,7 +26,6 @@ Checks:
   - 'modernize-*'
   - '-modernize-use-integer-sign-comparison'
   - '-modernize-use-nodiscard'
-  - '-modernize-use-equals-default'
   - '-modernize-return-braced-init-list'
   - '-modernize-use-auto'
   # END REMOVE ME

c/parallel/test/test_radix_sort.cpp

@@ -37,7 +37,7 @@ struct TestParameters
   static constexpr bool m_descending     = descending;
   static constexpr bool m_overwrite_okay = overwrite_okay;
 
-  constexpr TestParameters() {}
+  constexpr TestParameters() = default;
 
   bool is_descending() const
   {

c/parallel/test/test_segmented_sort.cpp

@@ -49,7 +49,7 @@ struct TestParameters
   static constexpr bool m_descending     = descending;
   static constexpr bool m_overwrite_okay = overwrite_okay;
 
-  constexpr TestParameters() {}
+  constexpr TestParameters() = default;
 
   constexpr bool is_descending() const
   {

c2h/include/c2h/checked_allocator.cuh

@@ -160,7 +160,7 @@ public:
     using other = checked_cuda_allocator<U>;
   };
 
-  _CCCL_HOST_DEVICE checked_cuda_allocator() {}
+  checked_cuda_allocator() = default;
 
   _CCCL_HOST_DEVICE checked_cuda_allocator(const checked_cuda_allocator& other)
       : base(other)
@@ -173,7 +173,7 @@ public:
 
   checked_cuda_allocator& operator=(const checked_cuda_allocator&) = default;
 
-  _CCCL_HOST_DEVICE ~checked_cuda_allocator() {}
+  ~checked_cuda_allocator() = default;
 };
 
 struct checked_host_memory_resource final : public THRUST_NS_QUALIFIER::mr::new_delete_resource_base

cub/cub/block/block_load_to_shared.cuh

@@ -228,7 +228,8 @@ private:
   class token_impl
   {
     friend struct BlockLoadToShared;
-    _CCCL_DEVICE_API _CCCL_FORCEINLINE token_impl() {} // ctor must have a body to avoid token_impl{} to compile
+    _CCCL_DEVICE_API _CCCL_FORCEINLINE token_impl() {} // NOLINT(modernize-use-equals-default) ctor must have a body to
+                                                       // avoid token_impl{} to compile
 
     // NOLINTBEGIN(modernize-use-equals-delete)
     token_impl(const token_impl&)            = delete;

cub/cub/thread/thread_operators.cuh

@@ -167,7 +167,7 @@ struct ScanBySegmentOp
   ScanOpT op;
 
   /// Constructor
-  _CCCL_HOST_DEVICE _CCCL_FORCEINLINE ScanBySegmentOp() {}
+  _CCCL_FORCEINLINE ScanBySegmentOp() = default;
 
   /// Constructor
   _CCCL_HOST_DEVICE _CCCL_FORCEINLINE ScanBySegmentOp(ScanOpT op)
@@ -301,7 +301,7 @@ struct ReduceBySegmentOp
   ReductionOpT op;
 
   /// Constructor
-  _CCCL_HOST_DEVICE _CCCL_FORCEINLINE ReduceBySegmentOp() {}
+  _CCCL_FORCEINLINE ReduceBySegmentOp() = default;
 
   /// Constructor
   _CCCL_HOST_DEVICE _CCCL_FORCEINLINE ReduceBySegmentOp(ReductionOpT op)
@@ -362,7 +362,7 @@ struct ReduceByKeyOp
   ReductionOpT op;
 
   /// Constructor
-  _CCCL_HOST_DEVICE _CCCL_FORCEINLINE ReduceByKeyOp() {}
+  _CCCL_FORCEINLINE ReduceByKeyOp() = default;
 
   /// Constructor
   _CCCL_HOST_DEVICE _CCCL_FORCEINLINE ReduceByKeyOp(ReductionOpT op)

cub/cub/util_type.cuh

@@ -704,11 +704,11 @@ struct KeyValuePair
   using Key   = _Key; ///< Key data type
   using Value = _Value; ///< Value data type
 
-  Key key; ///< Item key
-  Value value; ///< Item value
+  Key key{}; ///< Item key
+  Value value{}; ///< Item value
 
   /// Constructor
-  _CCCL_HOST_DEVICE _CCCL_FORCEINLINE KeyValuePair() {}
+  _CCCL_FORCEINLINE KeyValuePair() = default;
 
   /// Constructor
   _CCCL_HOST_DEVICE _CCCL_FORCEINLINE KeyValuePair(Key const& key, Value const& value)

cub/test/catch2_test_device_scan_iterators.cu

@@ -179,7 +179,7 @@ class custom_accumulator_t
   {}
 
 public:
-  __host__ __device__ custom_accumulator_t() {}
+  custom_accumulator_t() = default;
 
   __host__ __device__ custom_accumulator_t(const custom_accumulator_t& in)
       : m_val(in.is_valid() * in.get())

cub/test/catch2_test_device_transform.cu

@@ -521,10 +521,12 @@ struct non_trivial
       : data(data)
   {}
 
+  // NOLINTNEXTLINE(modernize-use-equals-default)
   __host__ __device__ non_trivial(const non_trivial& nt)
       : data(nt.data)
   {}
 
+  // NOLINTNEXTLINE(modernize-use-equals-default)
   __host__ __device__ auto operator=(const non_trivial& nt) -> non_trivial&
   {
     data = nt.data;

cudax/test/execution/common/utility.cuh

@@ -67,13 +67,16 @@ struct potentially_throwing
 
   _CCCL_HOST_DEVICE potentially_throwing(potentially_throwing&&) noexcept(false) {}
 
-  _CCCL_HOST_DEVICE potentially_throwing(const potentially_throwing&) noexcept(false) {}
+  _CCCL_HOST_DEVICE
+  potentially_throwing(const potentially_throwing&) noexcept(false) // NOLINT(modernize-use-equals-default)
+  {}
 
   _CCCL_HOST_DEVICE potentially_throwing& operator=(potentially_throwing&&) noexcept(false)
   {
     return *this;
   }
 
+  // NOLINTNEXTLINE(modernize-use-equals-default)
   _CCCL_HOST_DEVICE potentially_throwing& operator=(const potentially_throwing&) noexcept(false)
   {
     return *this;