modernize-return-braced-init-list

[Jacobfaib]

Description

closes

Checklist

• New or existing tests cover these changes.
• The documentation is up to date with these changes.

[fbusato]

don't have a strong opinion on that, slightly in favor. My concern is that I'm 100% that all compilers accept the new style

[github-actions]

🥳 CI Workflow Results

🟩 Finished in 5h 31m: Pass: 100%/381 | Total: 18d 12h | Max: 4h 18m | Hits: 19%/529350

See results here.

[miscco]

I am not in favor of this. IN our heavily templated code this might trigger especially the older compilers like GCC-7 which are not fully tested in PR CI

I am all for using {} for constructors, but we should retain the type

[Jacobfaib]

I am not in favor of this. IN our heavily templated code this might trigger especially the older compilers like GCC-7 which are not fully tested in PR CI

I am all for using {} for constructors, but we should retain the type

clang-tidy will only suggest replacement with {} when the return-type is unambiguously clear, i.e. when it is spelled out explicitly in the return type. If you take a look at the changes in this PR, you'll note that it does not specify a replacement for any templated types, only when the type is fully resolved.

Is there a mechanism where we can test older compilers in CI?

[Jacobfaib]

Since there seems to be no concerted votes for this feature, I will go ahead and close this PR and leave the check disabled.