Skip to content

Is cudax on main broken?#9283

Open
shwina wants to merge 1 commit into
NVIDIA:mainfrom
shwina:prove-main-broken
Open

Is cudax on main broken?#9283
shwina wants to merge 1 commit into
NVIDIA:mainfrom
shwina:prove-main-broken

Conversation

@shwina
Copy link
Copy Markdown
Contributor

@shwina shwina commented Jun 5, 2026

Description

closes

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@shwina shwina requested a review from a team as a code owner June 5, 2026 16:28
@shwina shwina requested a review from alliepiper June 5, 2026 16:28
@github-project-automation github-project-automation Bot moved this to Todo in CCCL Jun 5, 2026
@cccl-authenticator-app cccl-authenticator-app Bot moved this from Todo to In Review in CCCL Jun 5, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 5, 2026

Review Change Stack

Note: CodeRabbit is enabled on this repository as a convenience for maintainers
and contributors. Use your best judgment when considering its review comments and
suggestions — a suggested change may be inadequate, unnecessary, or safe to ignore.
Contributors are not expected to address every comment. Human reviews are what
ultimately matter for merging.

Summary

This pull request adds two additional build matrix entries for the cudax project in the CI configuration. The changes extend the workflows.override matrix to include builds targeting CUDA Toolkit versions 12.0 and 12.X with C++ standard 17 using GCC 9 compiler.

Changes

ci/matrix.yaml (+2 lines)

  • Added build entry for cudax with ctk: 12.0, std: 17, cxx: gcc9
  • Added build entry for cudax with ctk: 12.X, std: 17, cxx: gcc9

Walkthrough

Two build matrix entries added to ci/matrix.yaml for the cudax project targeting CUDA Toolkit versions 12.0 and 12.X with C++ standard 17 and GCC 9 compiler.

Changes

CI Configuration

Layer / File(s) Summary
Cudax build matrix extension
ci/matrix.yaml
Override workflow matrix extended with two new build entries for cudax on ctk 12.0 and 12.X, both using std 17 and cxx gcc9.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 82d4a811-06b7-45ff-a0c4-6377236168dc

📥 Commits

Reviewing files that changed from the base of the PR and between 281a0e4 and d8870a9.

📒 Files selected for processing (1)
  • ci/matrix.yaml

Comment thread ci/matrix.yaml
Comment on lines +24 to +25
- {jobs: ['build'], project: 'cudax', ctk: '12.0', std: 17, cxx: 'gcc9'}
- {jobs: ['build'], project: 'cudax', ctk: '12.X', std: 17, cxx: 'gcc9'}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

important: Override matrix blocks PR merge. Per CI guidelines and workflow-results action, reset to empty (not remove) before merging. This is expected behavior for testing but must be addressed prior to merge.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2026

😬 CI Workflow Results

🟥 Finished in 2m 32s: Pass: 0%/2 | Total: 4m 55s | Max: 2m 32s

See results here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

1 participant