Revert PR #580 streaming workaround (CCCL #1422 resolved)#810
Open
PointKernel wants to merge 1 commit intoNVIDIA:devfrom
Open
Revert PR #580 streaming workaround (CCCL #1422 resolved)#810PointKernel wants to merge 1 commit intoNVIDIA:devfrom
PointKernel wants to merge 1 commit intoNVIDIA:devfrom
Conversation
PointKernel
force-pushed
the
revert-pr-580-streaming
branch
from
a4b8172 to
7e00710
Compare
PointKernel
added
the
type: improvement
sleeepyjack
approved these changes
May 4, 2026
Comment on lines
+844
to
+862
| CUCO_CUDA_TRY(cub::DeviceSelect::If(nullptr, | ||
| temp_storage_bytes, | ||
| begin, | ||
| output_begin, | ||
| d_num_out, | ||
| this->capacity(), | ||
| is_filled, | ||
| stream.get())); | ||
|
|
||
| auto d_temp_storage = temp_allocator.allocate(temp_storage_bytes, stream); | ||
|
|
||
| CUCO_CUDA_TRY(cub::DeviceSelect::If(d_temp_storage, | ||
| temp_storage_bytes, | ||
| begin, | ||
| output_begin, | ||
| d_num_out, | ||
| this->capacity(), | ||
| is_filled, | ||
| stream.get())); |
Collaborator
There was a problem hiding this comment.
nit: Instead of the classical two-phase approach, we could use CUB's new single-phase API that takes an allocator: https://nvidia.github.io/cccl/unstable/cub/api_docs/device_wide.html#environment-api-single-phase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts the #580 streaming workaround as large size type is now supported by CUB.