fixup! feat(core.utils): retry os.replace on Windows ERROR_ACCESS_DENIED (winerror 5)

Author: cpcloud

cuda_core/cuda/core/utils/_program_cache.py

@@ -1067,7 +1067,7 @@ def _enforce_size_cap(self) -> None:
 _TMP_STALE_AGE_SECONDS = 3600
 
 
-_SHARING_VIOLATION_WINERRORS = (32, 33)  # ERROR_SHARING_VIOLATION, ERROR_LOCK_VIOLATION
+_SHARING_VIOLATION_WINERRORS = (5, 32, 33)  # ERROR_ACCESS_DENIED, ERROR_SHARING_VIOLATION, ERROR_LOCK_VIOLATION
 _REPLACE_RETRY_DELAYS = (0.0, 0.005, 0.010, 0.020, 0.050, 0.100)  # ~185ms budget
 
 
@@ -1078,6 +1078,11 @@ def _replace_with_sharing_retry(tmp_path: Path, target: Path) -> bool:
     exhausted on Windows with a genuine sharing violation -- the caller then
     treats the cache write as dropped. Any other ``PermissionError`` (ACLs,
     read-only dir, unexpected winerror, or any POSIX failure) propagates.
+
+    ``ERROR_ACCESS_DENIED`` (winerror 5) is treated as a sharing violation
+    because Windows surfaces it when a file is held open without
+    ``FILE_SHARE_WRITE`` (Python's default for ``open(p, "wb")``) or while
+    a previous unlink is in ``PENDING_DELETE`` -- both are transient.
     """
     for i, delay in enumerate(_REPLACE_RETRY_DELAYS):
         if delay:

cuda_core/tests/test_program_cache.py

@@ -1547,17 +1547,19 @@ def _denied(*args, **kwargs):
 @pytest.mark.parametrize(
     "winerror, should_raise",
     [
+        pytest.param(5, False, id="access_denied_swallowed"),
         pytest.param(32, False, id="sharing_violation_swallowed"),
         pytest.param(33, False, id="lock_violation_swallowed"),
-        pytest.param(5, True, id="access_denied_propagates"),
+        pytest.param(1, True, id="other_winerror_propagates"),
         pytest.param(None, True, id="no_winerror_propagates"),
     ],
 )
 def test_filestream_cache_permission_error_windows_is_narrowed(tmp_path, monkeypatch, winerror, should_raise):
-    """On Windows, only ERROR_SHARING_VIOLATION (32) and ERROR_LOCK_VIOLATION
-    (33) count as the "target held open by another process" case worth
-    swallowing. Any other PermissionError -- ACL issues, read-only dirs,
-    missing winerror attribute, etc. -- is a real problem and must propagate."""
+    """On Windows, ERROR_ACCESS_DENIED (5), ERROR_SHARING_VIOLATION (32) and
+    ERROR_LOCK_VIOLATION (33) are all transient "target held open by another
+    process / pending delete" cases worth swallowing after the bounded retry.
+    Any other PermissionError -- unrelated winerrors, missing winerror
+    attribute, etc. -- is a real problem and must propagate."""
     import os as _os
 
     from cuda.core.utils import FileStreamProgramCache, _program_cache