Standardize _validate_git_tags_available() across all three packages

Make _validate_git_tags_available() take tag_pattern as parameter and
ensure all three implementations (cuda-core, cuda-pathfinder, cuda-bindings)
are identical. Add sync comments to remind maintainers to keep them in sync.

Also fix ruff noqa comments: S603 on subprocess.run() line, S607 on
list argument line.

Author: rwgk

cuda_bindings/setup.py

@@ -25,9 +25,14 @@
 
 
 # ----------------------------------------------------------------------
+# Please keep the implementations in cuda-pathfinder, cuda-bindings, cuda-core in sync.
 # Validate git tags are available (fail early before setuptools-scm runs)
-def _validate_git_tags_available():
-    """Verify that git tags are available for setuptools-scm version detection."""
+def _validate_git_tags_available(tag_pattern: str) -> None:
+    """Verify that git tags are available for setuptools-scm version detection.
+
+    Args:
+        tag_pattern: Git tag pattern to match (e.g., "v*[0-9]*")
+    """
     import subprocess
 
     # Check if git is available
@@ -39,24 +44,14 @@ def _validate_git_tags_available():
             "Please ensure git is installed and available in your PATH."
         ) from None
 
-    # Check if we're in a git repository
-    try:
-        subprocess.run(
-            ["git", "rev-parse", "--git-dir"],  # noqa: S607
-            capture_output=True,
-            check=True,
-            timeout=5,
-        )
-    except subprocess.CalledProcessError:
-        raise RuntimeError(
-            "Not in a git repository. setuptools-scm requires git tags to determine version.\n"
-            "Please run this from within the cuda-python git repository."
-        ) from None
+    # Find git repository root (setuptools_scm root='..')
+    repo_root = os.path.dirname(os.path.dirname(__file__))
 
     # Check if git describe works (this is what setuptools-scm uses)
     try:
-        result = subprocess.run(
-            ["git", "describe", "--tags", "--long", "--match", "v*[0-9]*"],  # noqa: S607
+        result = subprocess.run(  # noqa: S603
+            ["git", "describe", "--tags", "--long", "--match", tag_pattern],  # noqa: S607
+            cwd=repo_root,
             capture_output=True,
             text=True,
             timeout=5,
@@ -75,7 +70,7 @@ def _validate_git_tags_available():
                 f"To fix:\n"
                 f"  git fetch --tags\n"
                 f"\n"
-                f"To debug, run: git describe --tags --long --match 'v*[0-9]*'"
+                f"To debug, run: git describe --tags --long --match '{tag_pattern}'"
             ) from None
     except subprocess.TimeoutExpired:
         raise RuntimeError(
@@ -84,7 +79,7 @@ def _validate_git_tags_available():
         ) from None
 
 
-_validate_git_tags_available()
+_validate_git_tags_available("v*[0-9]*")
 
 # ----------------------------------------------------------------------
 # Fetch configuration options

cuda_core/build_hooks.py

@@ -86,8 +86,13 @@ def _determine_cuda_major_version() -> str:
 _extensions = None
 
 
-def _build_cuda_core():
-    # Validate git tags are available (fail early before setuptools-scm runs)
+# Please keep the implementations in cuda-pathfinder, cuda-bindings, cuda-core in sync.
+def _validate_git_tags_available(tag_pattern: str) -> None:
+    """Verify that git tags are available for setuptools-scm version detection.
+
+    Args:
+        tag_pattern: Git tag pattern to match (e.g., "v*[0-9]*")
+    """
     import subprocess
 
     # Check if git is available
@@ -104,8 +109,8 @@ def _build_cuda_core():
 
     # Check if git describe works (this is what setuptools-scm uses)
     try:
-        result = subprocess.run(
-            ["git", "describe", "--tags", "--long", "--match", "cuda-core-v*[0-9]*"],  # noqa: S607
+        result = subprocess.run(  # noqa: S603
+            ["git", "describe", "--tags", "--long", "--match", tag_pattern],  # noqa: S607
             cwd=repo_root,
             capture_output=True,
             text=True,
@@ -125,14 +130,19 @@ def _build_cuda_core():
                 f"To fix:\n"
                 f"  git fetch --tags\n"
                 f"\n"
-                f"To debug, run: git describe --tags --long --match 'cuda-core-v*[0-9]*'"
+                f"To debug, run: git describe --tags --long --match '{tag_pattern}'"
             ) from None
     except subprocess.TimeoutExpired:
         raise RuntimeError(
             "git describe command timed out. This may indicate git repository issues.\n"
             "Please check your git repository state."
         ) from None
 
+
+def _build_cuda_core():
+    # Validate git tags are available (fail early before setuptools-scm runs)
+    _validate_git_tags_available("cuda-core-v*[0-9]*")
+
     # Customizing the build hooks is needed because we must defer cythonization until cuda-bindings,
     # now a required build-time dependency that's dynamically installed via the other hook below,
     # is installed. Otherwise, cimport any cuda.bindings modules would fail!

cuda_pathfinder/build_hooks.py

@@ -10,12 +10,17 @@
 """
 
 import os
-import subprocess
 
 
-# Validate tags before importing setuptools.build_meta (which will use setuptools-scm)
-def _validate_git_tags_available():
-    """Verify that git tags are available for setuptools-scm version detection."""
+# Please keep the implementations in cuda-pathfinder, cuda-bindings, cuda-core in sync.
+def _validate_git_tags_available(tag_pattern: str) -> None:
+    """Verify that git tags are available for setuptools-scm version detection.
+
+    Args:
+        tag_pattern: Git tag pattern to match (e.g., "v*[0-9]*")
+    """
+    import subprocess
+
     # Check if git is available
     try:
         subprocess.run(["git", "--version"], capture_output=True, check=True, timeout=5)  # noqa: S607
@@ -30,8 +35,8 @@ def _validate_git_tags_available():
 
     # Check if git describe works (this is what setuptools-scm uses)
     try:
-        result = subprocess.run(
-            ["git", "describe", "--tags", "--long", "--match", "cuda-pathfinder-v*[0-9]*"],  # noqa: S607
+        result = subprocess.run(  # noqa: S603
+            ["git", "describe", "--tags", "--long", "--match", tag_pattern],  # noqa: S607
             cwd=repo_root,
             capture_output=True,
             text=True,
@@ -51,7 +56,7 @@ def _validate_git_tags_available():
                 f"To fix:\n"
                 f"  git fetch --tags\n"
                 f"\n"
-                f"To debug, run: git describe --tags --long --match 'cuda-pathfinder-v*[0-9]*'"
+                f"To debug, run: git describe --tags --long --match '{tag_pattern}'"
             ) from None
     except subprocess.TimeoutExpired:
         raise RuntimeError(
@@ -61,7 +66,7 @@ def _validate_git_tags_available():
 
 
 # Validate tags before any build operations
-_validate_git_tags_available()
+_validate_git_tags_available("cuda-pathfinder-v*[0-9]*")
 
 # Import and re-export all PEP 517 hooks from setuptools.build_meta
 from setuptools.build_meta import *  # noqa: F403, E402