Address comments in PR

Author: mdboom

cuda_bindings/README.md

@@ -12,12 +12,8 @@ This subpackage adheres to the developing practices described in the parent meta
 
 ## Debugging
 
-Editable installs have debuggable binaries by default.  To build a non-editable
-debug build, pass the `debug=True` configuration option to `pip` or `uv`:
-
-```
-pip install -v ./cuda_bindings -C="debug=True"
-```
+Pass the `pip` / `uv` configuration option `-C="debug=True"` explicitly to build debuggable binaries.
+Debuggable binaries are built by default for editable builds.
 
 Debuggable builds are not supported on Windows.
 

cuda_bindings/build_hooks.py

@@ -355,7 +355,10 @@ def _build_cuda_bindings(debug=False):
     extra_compile_args = []
     extra_link_args = []
     extra_cythonize_kwargs = {}
-    if sys.platform != "win32":
+    if sys.platform == "win32":
+        if debug:
+            raise RuntimeError("Debuggable builds are not supported on Windows.")
+    else:
         extra_compile_args += [
             "-std=c++14",
             "-fpermissive",
@@ -428,7 +431,8 @@ def _cleanup_dst_files():
 
 
 def build_wheel(wheel_directory, config_settings=None, metadata_directory=None):
-    debug = config_settings.get("debug", False) if config_settings else False
+    debug_default = sys.platform != "win32"  # Debug builds not supported on Windows
+    debug = config_settings.get("debug", debug_default) if config_settings else debug_default
     _build_cuda_bindings(debug=debug)
     return _build_meta.build_wheel(wheel_directory, config_settings, metadata_directory)
 

cuda_core/README.md

@@ -12,12 +12,8 @@ This subpackage adheres to the developing practices described in the parent meta
 
 ## Debugging
 
-Editable installs have debuggable binaries by default.  To build a non-editable
-build, pass the `debug=True` configuration option to `pip` or `uv`:
-
-```
-pip install -v ./cuda_bindings -C="debug=True"
-```
+Pass the `pip` / `uv` configuration option `-C="debug=True"` explicitly to build debuggable binaries.
+Debuggable binaries are built by default for editable builds.
 
 Debuggable builds are not supported on Windows.
 

cuda_core/build_hooks.py

@@ -138,7 +138,10 @@ def get_sources(mod_name):
     extra_compile_args = []
     extra_link_args = []
     extra_cythonize_kwargs = {}
-    if sys.platform != "win32":
+    if sys.platform == "win32":
+        if debug:
+            raise RuntimeError("Debuggable builds are not supported on Windows.")
+    else:
         if debug:
             extra_cythonize_kwargs["gdb_debug"] = True
             extra_compile_args += ["-g", "-O0"]
@@ -266,7 +269,9 @@ def _add_cython_include_paths_to_pth(wheel_path: str) -> None:
 
 
 def build_editable(wheel_directory, config_settings=None, metadata_directory=None):
-    _build_cuda_core(debug=True)
+    debug_default = sys.platform != "win32"  # Debug builds not supported on Windows
+    debug = config_settings.get("debug", debug_default) if config_settings else debug_default
+    _build_cuda_core(debug=debug)
     wheel_name = _build_meta.build_editable(wheel_directory, config_settings, metadata_directory)
 
     # Patch the .pth file to add Cython include paths