Skip to content

Commit 1b9c4f0

Browse files
cpcloudleofang
andauthored
Apply suggestions from code review
Co-authored-by: Leo Fang <leof@nvidia.com>
1 parent b6d9e02 commit 1b9c4f0

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ jobs:
3232
cuda_build_ver=$(jq -r .cuda.build.version ci/versions.json)
3333
echo "cuda_build_ver=$cuda_build_ver" >> $GITHUB_OUTPUT
3434
35+
# WARNING: make sure all of the build jobs are in sync
3536
build-linux-64:
3637
needs:
3738
- ci-vars
@@ -48,6 +49,7 @@ jobs:
4849
host-platform: ${{ matrix.host-platform }}
4950
cuda-version: ${{ needs.ci-vars.outputs.CUDA_BUILD_VER }}
5051

52+
# WARNING: make sure all of the build jobs are in sync
5153
build-linux-aarch64:
5254
needs:
5355
- ci-vars
@@ -64,6 +66,7 @@ jobs:
6466
host-platform: ${{ matrix.host-platform }}
6567
cuda-version: ${{ needs.ci-vars.outputs.CUDA_BUILD_VER }}
6668

69+
# WARNING: make sure all of the build jobs are in sync
6770
build-windows:
6871
needs:
6972
- ci-vars
@@ -80,6 +83,7 @@ jobs:
8083
host-platform: ${{ matrix.host-platform }}
8184
cuda-version: ${{ needs.ci-vars.outputs.CUDA_BUILD_VER }}
8285

86+
# WARNING: make sure both Linux test jobs are in sync
8387
test-linux-64:
8488
strategy:
8589
fail-fast: false
@@ -100,6 +104,7 @@ jobs:
100104
host-platform: ${{ matrix.host-platform }}
101105
build-ctk-ver: ${{ needs.ci-vars.outputs.CUDA_BUILD_VER }}
102106

107+
# WARNING: make sure both Linux test jobs are in sync
103108
test-linux-aarch64:
104109
strategy:
105110
fail-fast: false
@@ -151,8 +156,6 @@ jobs:
151156
needs:
152157
- ci-vars
153158
- build-linux-64
154-
- build-linux-aarch64
155-
- build-windows
156159
secrets: inherit
157160
uses: ./.github/workflows/build-docs.yml
158161
with:

0 commit comments

Comments
 (0)