Skip to content

Commit 20c5a99

Browse files
committed
address review comments
1 parent 0471e44 commit 20c5a99

3 files changed

Lines changed: 5 additions & 6 deletions

File tree

.github/workflows/build-wheel.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,6 @@ jobs:
155155
path: ${{ env.CUDA_BINDINGS_ARTIFACTS_DIR }}/*.whl
156156
if-no-files-found: error
157157

158-
# TODO: ideally we want to build against public cuda-bindings
159158
- name: Build cuda.core wheel
160159
uses: pypa/cibuildwheel@c923d83ad9c1bc00211c5041d0c3f73294ff88f6 # v3.1.4
161160
with:
@@ -289,7 +288,6 @@ jobs:
289288
cuda-version: ${{ inputs.prev-cuda-version }}
290289
cuda-path: "./cuda_toolkit_prev"
291290

292-
# TODO: ideally we want to build against public cuda-bindings
293291
- name: Download cuda.bindings build artifacts from the prior branch
294292
if: ${{ matrix.python-version == '3.13t'
295293
|| matrix.python-version == '3.14'

ci/tools/merge_cuda_core_wheels.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1+
#!/usr/bin/env python3
2+
13
# SPDX-FileCopyrightText: Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
24
#
35
# SPDX-License-Identifier: Apache-2.0
46

5-
#!/usr/bin/env python3
67
"""
78
Script to merge CUDA-specific wheels into a single multi-CUDA wheel.
89

cuda_core/cuda/core/experimental/__init__.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,14 @@
1515

1616
subdir = f"cu{cuda_major}"
1717
try:
18-
verioned_mod = importlib.import_module(f".{subdir}", __package__)
18+
versioned_mod = importlib.import_module(f".{subdir}", __package__)
1919
# Import all symbols from the module
20-
globals().update(verioned_mod.__dict__)
20+
globals().update(versioned_mod.__dict__)
2121
except ImportError:
2222
# This is not a wheel build, but a conda or local build, do nothing
2323
pass
2424
else:
25-
del verioned_mod
25+
del versioned_mod
2626
finally:
2727
del cuda.bindings, importlib, subdir, cuda_major, cuda_minor
2828

0 commit comments

Comments
 (0)