Skip to content

Commit 22b3800

Browse files
committed
cuda.core: fix int(condition) call sites missed when removing GraphCondition.__int__ (#1945)
The conditional builder methods (if_then, if_else, switch, while_loop) were still calling int(condition) on the GraphCondition object after __int__ was removed in the prior commit. Use the public .handle property instead, which mirrors the kernel argument handler fix. This was caught by CI: 26 conditional graph tests failed with TypeError in cuda/core/graph/_graph_builder.pyx:549. Made-with: Cursor
1 parent 6469028 commit 22b3800

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

cuda_core/cuda/core/graph/_graph_builder.pyx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -546,7 +546,7 @@ class GraphBuilder:
546546
f"GraphBuilder.create_condition()), got {type(condition).__name__}")
547547
node_params = driver.CUgraphNodeParams()
548548
node_params.type = driver.CUgraphNodeType.CU_GRAPH_NODE_TYPE_CONDITIONAL
549-
node_params.conditional.handle = int(condition)
549+
node_params.conditional.handle = condition.handle
550550
node_params.conditional.type = driver.CUgraphConditionalNodeType.CU_GRAPH_COND_TYPE_IF
551551
node_params.conditional.size = 1
552552
node_params.conditional.ctx = self._get_conditional_context()
@@ -582,7 +582,7 @@ class GraphBuilder:
582582
f"GraphBuilder.create_condition()), got {type(condition).__name__}")
583583
node_params = driver.CUgraphNodeParams()
584584
node_params.type = driver.CUgraphNodeType.CU_GRAPH_NODE_TYPE_CONDITIONAL
585-
node_params.conditional.handle = int(condition)
585+
node_params.conditional.handle = condition.handle
586586
node_params.conditional.type = driver.CUgraphConditionalNodeType.CU_GRAPH_COND_TYPE_IF
587587
node_params.conditional.size = 2
588588
node_params.conditional.ctx = self._get_conditional_context()
@@ -621,7 +621,7 @@ class GraphBuilder:
621621
f"GraphBuilder.create_condition()), got {type(condition).__name__}")
622622
node_params = driver.CUgraphNodeParams()
623623
node_params.type = driver.CUgraphNodeType.CU_GRAPH_NODE_TYPE_CONDITIONAL
624-
node_params.conditional.handle = int(condition)
624+
node_params.conditional.handle = condition.handle
625625
node_params.conditional.type = driver.CUgraphConditionalNodeType.CU_GRAPH_COND_TYPE_SWITCH
626626
node_params.conditional.size = count
627627
node_params.conditional.ctx = self._get_conditional_context()
@@ -657,7 +657,7 @@ class GraphBuilder:
657657
f"GraphBuilder.create_condition()), got {type(condition).__name__}")
658658
node_params = driver.CUgraphNodeParams()
659659
node_params.type = driver.CUgraphNodeType.CU_GRAPH_NODE_TYPE_CONDITIONAL
660-
node_params.conditional.handle = int(condition)
660+
node_params.conditional.handle = condition.handle
661661
node_params.conditional.type = driver.CUgraphConditionalNodeType.CU_GRAPH_COND_TYPE_WHILE
662662
node_params.conditional.size = 1
663663
node_params.conditional.ctx = self._get_conditional_context()

0 commit comments

Comments
 (0)