Skip to content

Commit 387b7a9

Browse files
rparolinclaude
andcommitted
Address PR review feedback for pr-metadata-check workflow
- Fix case sensitivity: 'nvidia' → 'NVIDIA' (job never ran as-is) - Re-add milestoned/demilestoned activity types (valid for pull_request_target) - Update copyright year to include 2026 - Add PR metadata guidance to AGENTS.md for label/milestone enforcement Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 81daf16 commit 387b7a9

2 files changed

Lines changed: 20 additions & 2 deletions

File tree

.github/workflows/pr-metadata-check.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# SPDX-FileCopyrightText: Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
1+
# SPDX-FileCopyrightText: Copyright (c) 2024-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
22
#
33
# SPDX-License-Identifier: Apache-2.0
44

@@ -12,12 +12,14 @@ on:
1212
- synchronize
1313
- labeled
1414
- unlabeled
15+
- milestoned
16+
- demilestoned
1517

1618
jobs:
1719
check-metadata:
1820
name: PR has labels and milestone
19-
if: github.repository_owner == 'nvidia'
2021
if: github.repository_owner == 'NVIDIA'
22+
runs-on: ubuntu-latest
2123
steps:
2224
- name: Check for labels and milestone
2325
env:

AGENTS.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,22 @@ guide for package-specific conventions and workflows.
1212
- `cuda_core/`: High-level Pythonic CUDA APIs built on top of bindings.
1313
- `cuda_python/`: Metapackage and docs aggregation.
1414

15+
# Pull requests
16+
17+
When creating pull requests with `gh pr create`, always assign at least one
18+
label and a milestone. CI enforces this via the `pr-metadata-check` workflow
19+
and will block PRs that are missing labels or a milestone. Use `--label` and
20+
`--milestone` flags, for example:
21+
22+
```
23+
gh pr create --title "..." --body "..." --label "bug" --milestone "v1.0"
24+
```
25+
26+
If you are unsure which label or milestone to use, check the existing labels
27+
and milestones on the repository with `gh label list` and `gh api
28+
repos/{owner}/{repo}/milestones --jq '.[].title'`, and pick the best match.
29+
30+
1531
# General
1632

1733
- When searching for text or files, prefer using `rg` or `rg --files`

0 commit comments

Comments
 (0)