Skip to content

Commit 398b28d

Browse files
committed
Address comments in PR
1 parent 2b01980 commit 398b28d

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

cuda_bindings/build_hooks.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -459,12 +459,13 @@ def _cleanup_dst_files():
459459

460460

461461
def build_wheel(wheel_directory, config_settings=None, metadata_directory=None):
462-
debug_default = sys.platform != "win32" # Debug builds not supported on Windows
463-
debug = config_settings.get("debug", debug_default) if config_settings else debug_default
462+
debug = config_settings.get("debug", False) if config_settings else False
464463
_build_cuda_bindings(debug=debug)
465464
return _build_meta.build_wheel(wheel_directory, config_settings, metadata_directory)
466465

467466

468467
def build_editable(wheel_directory, config_settings=None, metadata_directory=None):
469-
_build_cuda_bindings(debug=True)
468+
debug_default = sys.platform != "win32" # Debug builds not supported on Windows
469+
debug = config_settings.get("debug", debug_default) if config_settings else debug_default
470+
_build_cuda_bindings(debug=debug)
470471
return _build_meta.build_editable(wheel_directory, config_settings, metadata_directory)

0 commit comments

Comments
 (0)