Skip to content

Commit 552c3c6

Browse files
committed
Remove default values for libname in _make_bitcode_lib_file and _bitcode_lib_dir_under
Signed-off-by: Xiakun Lu <xiakunl@nvidia.com>
1 parent b559dcf commit 552c3c6

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

cuda_pathfinder/tests/test_find_bitcode_lib.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,14 @@ def clear_find_bitcode_lib_cache():
3636
get_cuda_path_or_home.cache_clear()
3737

3838

39-
def _make_bitcode_lib_file(dir_path: Path, libname: str = "device") -> str:
39+
def _make_bitcode_lib_file(dir_path: Path, libname: str) -> str:
4040
dir_path.mkdir(parents=True, exist_ok=True)
4141
file_path = dir_path / _bitcode_lib_filename(libname)
4242
file_path.touch()
4343
return str(file_path)
4444

4545

46-
def _bitcode_lib_dir_under(anchor_dir: Path, libname: str = "device") -> Path:
46+
def _bitcode_lib_dir_under(anchor_dir: Path, libname: str) -> Path:
4747
return anchor_dir / _bitcode_lib_info(libname)["rel_path"]
4848

4949

@@ -138,7 +138,7 @@ def find_expected_sub_dir(sub_dir):
138138
@pytest.mark.usefixtures("clear_find_bitcode_lib_cache")
139139
def test_find_bitcode_lib_not_found_error_includes_cuda_home_directory_listing(monkeypatch, tmp_path):
140140
cuda_home = tmp_path / "cuda-home"
141-
lib_dir = _bitcode_lib_dir_under(cuda_home)
141+
lib_dir = _bitcode_lib_dir_under(cuda_home, "device")
142142
lib_dir.mkdir(parents=True, exist_ok=True)
143143
extra_file = lib_dir / "README.txt"
144144
extra_file.write_text("placeholder", encoding="utf-8")

0 commit comments

Comments
 (0)