Skip to content

Commit 5a4c420

Browse files
kkraus14cursoragent
andcommitted
Address second round of review comments
- Replace duplicated test deps in build-wheel.yml with uv sync --package <pkg> --only-group test --no-install-project. - Improve conflict comments to clarify they are about cuda-toolkit version constraints, not cuda-bindings compatibility. Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 541ac24 commit 5a4c420

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

.github/workflows/build-wheel.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ jobs:
307307
- name: Build cuda.bindings Cython tests
308308
run: |
309309
uv pip install ${{ env.CUDA_BINDINGS_ARTIFACTS_DIR }}/*.whl
310-
uv pip install "pytest>=6.2.4" "pytest-benchmark>=3.4.1" pytest-randomly pytest-repeat "pyglet>=2.1.9" "numpy>=1.21.1" "cython>=3.2,<3.3" "setuptools>=77.0.0"
310+
uv sync --package cuda-bindings --only-group test --no-install-project
311311
pushd ${{ env.CUDA_BINDINGS_CYTHON_TESTS_DIR }}
312312
bash build_tests.sh
313313
popd
@@ -322,7 +322,7 @@ jobs:
322322
- name: Build cuda.core Cython tests
323323
run: |
324324
uv pip install ${{ env.CUDA_CORE_ARTIFACTS_DIR }}/"cu${BUILD_CUDA_MAJOR}"/*.whl
325-
uv pip install "pytest>=6.2.4" pytest-randomly pytest-repeat "cython>=3.2,<3.3" setuptools
325+
uv sync --package cuda-core --only-group test --no-install-project
326326
pushd ${{ env.CUDA_CORE_CYTHON_TESTS_DIR }}
327327
bash build_tests.sh
328328
popd

pyproject.toml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,9 @@ conflicts = [
5656
{ package = "cuda-pathfinder", group = "test-cu12" },
5757
{ package = "cuda-pathfinder", group = "cu13" },
5858
],
59-
# cuda-bindings[all] pins cuda-toolkit==13.* which conflicts with cu12 groups
59+
# cuda-bindings[all] in this workspace requires cuda-toolkit==13.*.
60+
# Any group that requires cuda-toolkit==12.* is unsatisfiable alongside
61+
# it, regardless of which cuda-bindings major version pathfinder supports.
6062
[
6163
{ package = "cuda-bindings", extra = "all" },
6264
{ package = "cuda-core", group = "test-cu12" },

0 commit comments

Comments
 (0)