Skip to content

Commit 67228b4

Browse files
authored
Merge branch 'main' into merged-docs-output
2 parents b768bdb + 4cea0a1 commit 67228b4

28 files changed

Lines changed: 1171 additions & 1174 deletions

.github/workflows/pr-metadata-check.yml

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,27 +2,30 @@
22
#
33
# SPDX-License-Identifier: Apache-2.0
44

5-
name: "CI: Enforce label/milestone on PRs"
5+
name: "CI: Enforce assignee/label/milestone on PRs"
66

77
on:
88
pull_request_target:
99
types:
1010
- opened
1111
- edited
1212
- synchronize
13+
- assigned
14+
- unassigned
1315
- labeled
1416
- unlabeled
1517
- reopened
1618
- ready_for_review
1719

1820
jobs:
1921
check-metadata:
20-
name: PR has labels and milestone
22+
name: PR has assignee, labels, and milestone
2123
if: github.repository_owner == 'NVIDIA'
2224
runs-on: ubuntu-latest
2325
steps:
24-
- name: Check for labels and milestone
26+
- name: Check for assignee, labels, and milestone
2527
env:
28+
ASSIGNEES: ${{ toJson(github.event.pull_request.assignees) }}
2629
LABELS: ${{ toJson(github.event.pull_request.labels) }}
2730
MILESTONE: ${{ github.event.pull_request.milestone && github.event.pull_request.milestone.title || '' }}
2831
PR_URL: ${{ github.event.pull_request.html_url }}
@@ -34,14 +37,21 @@ jobs:
3437
exit 0
3538
fi
3639
37-
LABEL_NAMES=$(echo "$LABELS" | jq -r '.[].name')
3840
ERRORS=""
3941
42+
ASSIGNEE_COUNT=$(echo "$ASSIGNEES" | jq 'length')
43+
if [ "$ASSIGNEE_COUNT" -eq 0 ]; then
44+
ERRORS="${ERRORS}- **Missing assignee**: assign at least one person to this PR.\n"
45+
fi
46+
4047
# Module labels identify which package the PR touches.
48+
# Cross-cutting labels exempt PRs from needing a module label.
49+
LABEL_NAMES=$(echo "$LABELS" | jq -r '.[].name')
4150
MODULE_LABELS="cuda.bindings cuda.core cuda.pathfinder"
51+
MODULE_EXEMPT_LABELS="CI/CD"
4252
HAS_MODULE=false
4353
for label in $LABEL_NAMES; do
44-
for mod in $MODULE_LABELS; do
54+
for mod in $MODULE_LABELS $MODULE_EXEMPT_LABELS; do
4555
if [ "$label" = "$mod" ]; then
4656
HAS_MODULE=true
4757
break 2
@@ -50,7 +60,7 @@ jobs:
5060
done
5161
5262
if [ "$HAS_MODULE" = "false" ]; then
53-
ERRORS="${ERRORS}- **Missing module label**: add at least one of: \`cuda.bindings\`, \`cuda.core\`, \`cuda.pathfinder\`.\n"
63+
ERRORS="${ERRORS}- **Missing module label**: add at least one of: \`cuda.bindings\`, \`cuda.core\`, \`cuda.pathfinder\` (or a cross-cutting label such as \`CI/CD\`).\n"
5464
fi
5565
5666
# Type labels categorize the kind of change.
@@ -89,17 +99,19 @@ jobs:
8999
{
90100
echo "## PR Metadata Check Failed"
91101
echo ""
92-
printf "$ERRORS"
102+
printf '%b' "$ERRORS"
93103
echo ""
94104
echo "Please update the PR at: $PR_URL"
95105
} >> "$GITHUB_STEP_SUMMARY"
96106
exit 1
97107
fi
98108
109+
ASSIGNEE_LIST=$(echo "$ASSIGNEES" | jq -r '.[].login' | paste -sd ', ' -)
99110
LABEL_LIST=$(echo "$LABEL_NAMES" | paste -sd ', ' -)
100111
{
101112
echo "## PR Metadata Check Passed"
102113
echo ""
114+
echo "- **Assignees**: $ASSIGNEE_LIST"
103115
echo "- **Labels**: $LABEL_LIST"
104116
echo "- **Milestone**: $MILESTONE"
105117
} >> "$GITHUB_STEP_SUMMARY"

.github/workflows/test-wheel-windows.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,7 @@ jobs:
263263
}
264264
265265
- name: Install cuda.pathfinder extra wheels for testing
266+
if: ${{ !endsWith(matrix.PY_VER, 't') }} # see issue #1820
266267
shell: bash --noprofile --norc -xeuo pipefail {0}
267268
run: |
268269
pushd cuda_pathfinder
@@ -271,6 +272,7 @@ jobs:
271272
popd
272273
273274
- name: Run cuda.pathfinder tests with all_must_work
275+
if: ${{ !endsWith(matrix.PY_VER, 't') }} # see issue #1820
274276
env:
275277
CUDA_PATHFINDER_TEST_LOAD_NVIDIA_DYNAMIC_LIB_STRICTNESS: all_must_work
276278
CUDA_PATHFINDER_TEST_FIND_NVIDIA_HEADERS_STRICTNESS: all_must_work

0 commit comments

Comments
 (0)