Skip to content

Commit 6897c26

Browse files
authored
Merge pull request #498 from rwgk/fix_test_timing_flakiness
Increase tolerance in `test_timing()` to avoid flaky tests.
2 parents 9cb6e82 + 41d493e commit 6897c26

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

cuda_core/tests/test_event.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,12 @@ def test_timing(init_cuda, enable_timing):
3333
if enable_timing:
3434
elapsed_time_ms = e2 - e1
3535
assert isinstance(elapsed_time_ms, float)
36-
assert delay_seconds * 1000 <= elapsed_time_ms < delay_seconds * 1000 + 2 # tolerance 2 ms
36+
# Using a generous tolerance, to avoid flaky tests:
37+
# We only want to exercise the __sub__ method, this test is not meant
38+
# to stress-test the CUDA driver or time.sleep().
39+
delay_ms = delay_seconds * 1000
40+
generous_tolerance = 20
41+
assert delay_ms <= elapsed_time_ms < delay_ms + generous_tolerance
3742
else:
3843
with pytest.raises(RuntimeError) as e:
3944
elapsed_time_ms = e2 - e1

0 commit comments

Comments
 (0)