Fix pre-commit findings: ruff (SIM103, isort), ruff-format, mypy

- Inline boolean return in `_is_expected_find_failure`.
- Re-sort imports / let ruff-format reflow long signatures.
- Restructure the `find_nvidia_dynamic_lib` STATUS_OK / error-message
  branches so mypy can narrow `payload.abs_path` to `str`.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: rparolin

cuda_pathfinder/cuda/pathfinder/__init__.py

@@ -11,16 +11,16 @@
     find_nvidia_binary_utility as find_nvidia_binary_utility,
 )
 from cuda.pathfinder._binaries.supported_nvidia_binaries import SUPPORTED_BINARIES as _SUPPORTED_BINARIES
+from cuda.pathfinder._dynamic_libs.find_nvidia_dynamic_lib import (
+    find_nvidia_dynamic_lib as find_nvidia_dynamic_lib,
+)
 from cuda.pathfinder._dynamic_libs.load_dl_common import (
     DynamicLibNotAvailableError as DynamicLibNotAvailableError,
 )
 from cuda.pathfinder._dynamic_libs.load_dl_common import DynamicLibNotFoundError as DynamicLibNotFoundError
 from cuda.pathfinder._dynamic_libs.load_dl_common import (
     DynamicLibUnknownError as DynamicLibUnknownError,
 )
-from cuda.pathfinder._dynamic_libs.find_nvidia_dynamic_lib import (
-    find_nvidia_dynamic_lib as find_nvidia_dynamic_lib,
-)
 from cuda.pathfinder._dynamic_libs.load_dl_common import LoadedDL as LoadedDL
 from cuda.pathfinder._dynamic_libs.load_nvidia_dynamic_lib import load_nvidia_dynamic_lib as load_nvidia_dynamic_lib
 from cuda.pathfinder._dynamic_libs.supported_nvidia_libs import (

cuda_pathfinder/cuda/pathfinder/_dynamic_libs/find_nvidia_dynamic_lib.py

@@ -79,12 +79,13 @@ def find_nvidia_dynamic_lib(libname: str) -> str:
         error_label=f"find_nvidia_dynamic_lib subprocess for {libname!r}",
     )
     if payload.status == STATUS_OK:
-        assert payload.abs_path is not None
-        return payload.abs_path
+        abs_path: str | None = payload.abs_path
+        assert abs_path is not None
+        return abs_path
 
-    message = (
-        payload.error["message"]
-        if payload.error and "message" in payload.error
-        else f"find_nvidia_dynamic_lib could not locate {libname!r}"
-    )
+    error = payload.error
+    if error is not None and "message" in error:
+        message = error["message"]
+    else:
+        message = f"find_nvidia_dynamic_lib could not locate {libname!r}"
     raise DynamicLibNotFoundError(message)

cuda_pathfinder/cuda/pathfinder/_dynamic_libs/subprocess_protocol.py

@@ -128,9 +128,7 @@ def run_dynamic_lib_subprocess(
             cwd=DYNAMIC_LIB_SUBPROCESS_CWD,
         )
     except subprocess.TimeoutExpired as exc:
-        raise_subprocess_child_process_error(
-            error_label, timeout=exc.timeout, stdout=exc.stdout, stderr=exc.stderr
-        )
+        raise_subprocess_child_process_error(error_label, timeout=exc.timeout, stdout=exc.stdout, stderr=exc.stderr)
 
     if result.returncode != 0:
         raise_subprocess_child_process_error(

cuda_pathfinder/tests/test_find_nvidia_dynamic_lib.py

@@ -32,9 +32,7 @@ def test_unknown_libname_raises_dynamic_lib_unknown_error():
 
 def test_known_but_platform_unavailable_libname_raises_dynamic_lib_not_available_error(monkeypatch):
     find_nvidia_dynamic_lib.cache_clear()
-    monkeypatch.setattr(
-        load_nvidia_dynamic_lib_module, "_ALL_KNOWN_LIBNAMES", frozenset(("known_but_unavailable",))
-    )
+    monkeypatch.setattr(load_nvidia_dynamic_lib_module, "_ALL_KNOWN_LIBNAMES", frozenset(("known_but_unavailable",)))
     monkeypatch.setattr(load_nvidia_dynamic_lib_module, "_ALL_SUPPORTED_LIBNAMES", frozenset())
     monkeypatch.setattr(load_nvidia_dynamic_lib_module, "_PLATFORM_NAME", "TestOS")
     with pytest.raises(
@@ -47,9 +45,7 @@ def test_known_but_platform_unavailable_libname_raises_dynamic_lib_not_available
 def _is_expected_find_failure(libname: str) -> bool:
     # Mirror load-side strictness: libnames known to fail loading on this
     # platform are also allowed to fail finding.
-    if libname == "nvpl_fftw" and platform.machine().lower() != "aarch64":
-        return True
-    return False
+    return libname == "nvpl_fftw" and platform.machine().lower() != "aarch64"
 
 
 @pytest.mark.parametrize(