Skip to content

Commit 7c8cd52

Browse files
committed
Address copilot's suggestions
1 parent b52307f commit 7c8cd52

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

toolshed/update_ctk.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ def update_config(version: str, config_path: Path) -> None:
8484
f.write("".join(out))
8585

8686

87-
def run_cybind(cybind_repo: Path, cuda_python_repo: Path, libraries: list[str]) -> None:
87+
def run_cybind(cybind_repo: Path, cuda_python_repo: Path, libraries: list[str]) -> int:
8888
with tempfile.TemporaryDirectory() as tempdir:
8989
tempdir_path = Path(tempdir)
9090

@@ -116,6 +116,8 @@ def run_cybind(cybind_repo: Path, cuda_python_repo: Path, libraries: list[str])
116116
print("If necessary, you can edit the headers and re-run this script.")
117117
return 1
118118

119+
return 0
120+
119121

120122
def update_version_file(version: str, version_path: Path, is_prev: bool) -> str:
121123
if is_prev:
@@ -129,7 +131,7 @@ def update_version_file(version: str, version_path: Path, is_prev: bool) -> str:
129131
content["cuda"][key]["version"] = version
130132

131133
with version_path.open("w") as f:
132-
content = json.dump(content, f, indent=2)
134+
json.dump(content, f, indent=2)
133135
# json.dump doesn't add a trailing newline
134136
f.write("\n")
135137

@@ -197,6 +199,7 @@ def main(version: str, cuda_python_repo: Path, cybind_repo: Path, is_prev: bool)
197199
resp = input().strip().lower()
198200
if resp != "y":
199201
print("Aborting")
202+
sys.exit(0)
200203

201204
main(args.version, cuda_python_repo, args.cybind_repo, args.is_prev)
202205

0 commit comments

Comments
 (0)