fixup! feat(core.utils): use collections.abc.Sequence to match _prepare_nvrtc_options_impl

Author: cpcloud

cuda_core/cuda/core/utils/_program_cache.py

@@ -18,6 +18,7 @@
 from __future__ import annotations
 
 import abc
+import collections.abc
 import contextlib
 import hashlib
 import os
@@ -332,9 +333,15 @@ def _option_is_set(options: ProgramOptions, name: str) -> bool:
     if name in _BOOLEAN_OPTION_FIELDS:
         return bool(value)
     if name in _STR_OR_SEQUENCE_OPTION_FIELDS:
+        # Mirror ``_prepare_nvrtc_options_impl``: it checks ``isinstance(v, str)``
+        # first, then ``is_sequence(v)`` (which is ``isinstance(v, Sequence)``).
+        # We therefore accept any ``collections.abc.Sequence`` (range, deque,
+        # user subclass, etc.), not just list/tuple.
         if isinstance(value, str):
             return True
-        return isinstance(value, (list, tuple)) and len(value) > 0
+        if isinstance(value, collections.abc.Sequence):
+            return len(value) > 0
+        return False
     return True
 
 

cuda_core/tests/test_program_cache.py

@@ -431,6 +431,9 @@ def _flaky_replace(src, dst):
         pytest.param({"pre_include": "stdint.h"}, id="pre_include"),
         pytest.param({"pch": True}, id="pch"),
         pytest.param({"pch_dir": "pch-cache"}, id="pch_dir"),
+        # Non-list/tuple Sequence: the compiler iterates it via ``is_sequence``
+        # (``isinstance(v, Sequence)``), so the guard must too.
+        pytest.param({"include_path": range(1)}, id="include_path_nonempty_range"),
         # Empty-string path-like options -- NVRTC still emits a flag
         # (``--use-pch=``, ``--pch-dir=``, ``--pre-include=``) so the guard
         # must fire for them too.
@@ -466,6 +469,10 @@ def test_make_program_cache_key_rejects_external_content_without_extra_digest(op
         # is silently ignored at compile time and must not trip the guard.
         pytest.param({"include_path": False}, id="include_path_false"),
         pytest.param({"pre_include": False}, id="pre_include_false"),
+        # Empty non-list/tuple Sequence: ``_prepare_nvrtc_options_impl`` uses
+        # ``is_sequence`` (i.e. ``isinstance(v, Sequence)``); a zero-length
+        # sequence produces no emission regardless of type.
+        pytest.param({"include_path": range(0)}, id="include_path_empty_range"),
     ],
 )
 def test_make_program_cache_key_accepts_empty_external_content(option_kw):