Skip to content

Commit 8d2d1d2

Browse files
authored
Move release CI tools tests to nightly (#2279)
* move testing release tools to nightly * ci: skip root conftest when running ci/tools/tests in nightly
1 parent d9831c4 commit 8d2d1d2

3 files changed

Lines changed: 23 additions & 9 deletions

File tree

.github/workflows/ci-nightly.yml

Lines changed: 23 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,9 @@
33
# SPDX-License-Identifier: Apache-2.0
44

55
# Nightly CI pipeline that tests optional dependencies (PyTorch, numba-cuda)
6-
# against the latest cuda-python wheels built on main, and runs the standard
7-
# test suite on runners reserved for nightly-only use (e.g. arm64 l4×2).
6+
# against the latest cuda-python wheels built on main, runs the standard
7+
# test suite on runners reserved for nightly-only use (e.g. arm64 l4×2), and
8+
# exercises release-time CI helper scripts so they do not silently rot between releases.
89
#
910
# This workflow does NOT build wheels — it downloads them from the latest
1011
# successful CI run on main and runs integration/standard tests.
@@ -31,6 +32,22 @@ on:
3132
default: ''
3233

3334
jobs:
35+
test-ci-tools-for-release:
36+
name: "Nightly: CI tools for release"
37+
if: ${{ github.repository_owner == 'nvidia' }}
38+
runs-on: ubuntu-latest
39+
steps:
40+
- name: Checkout repository
41+
uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
42+
with:
43+
fetch-depth: 1
44+
45+
- name: Run CI tools unit tests
46+
run: |
47+
python -m pip install pytest
48+
# Standalone CI tool tests; skip repo-root conftest.py (imports cuda.pathfinder).
49+
python -m pytest -v --noconftest ci/tools/tests
50+
3451
find-wheels:
3552
runs-on: ubuntu-latest
3653
outputs:
@@ -219,6 +236,7 @@ jobs:
219236
if: always()
220237
runs-on: ubuntu-latest
221238
needs:
239+
- test-ci-tools-for-release
222240
- find-wheels
223241
- test-pytorch-linux
224242
- test-pytorch-linux-aarch64
@@ -235,7 +253,9 @@ jobs:
235253
# See ci.yml for the full rationale on why we must use always()
236254
# and explicitly check each result rather than relying on the
237255
# default behaviour.
238-
if ${{ needs.find-wheels.result != 'success' }}; then
256+
if ${{ needs.test-ci-tools-for-release.result == 'cancelled' ||
257+
needs.test-ci-tools-for-release.result == 'failure' ||
258+
needs.find-wheels.result != 'success' }}; then
239259
exit 1
240260
fi
241261
if ${{ needs.test-pytorch-linux.result == 'cancelled' ||

.github/workflows/release.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -164,11 +164,6 @@ jobs:
164164
with:
165165
python-version: "3.12"
166166

167-
# - name: Self-test release-notes checker
168-
# run: |
169-
# pip install pytest
170-
# pytest ci/tools/tests
171-
172167
- name: Check versioned release notes exist
173168
run: |
174169
python ci/tools/check_release_notes.py \

pytest.ini

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ testpaths =
1212
cuda_bindings/tests
1313
cuda_core/tests
1414
tests/integration
15-
ci/tools/tests
1615

1716
markers =
1817
pathfinder: tests for cuda_pathfinder

0 commit comments

Comments
 (0)