Skip to content

Commit 8d78582

Browse files
committed
docs(pathfinder): address review feedback
Use the requested fully-isolated subprocess wording, restore the historical 1.4.0 release note text, and add new 1.4.3 release notes for the script-safety and import-root fixes instead. Made-with: Cursor
1 parent b702b7a commit 8d78582

3 files changed

Lines changed: 25 additions & 3 deletions

File tree

cuda_pathfinder/cuda/pathfinder/_headers/find_nvidia_headers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ def find_via_ctk_root_canary(desc: HeaderDescriptor) -> LocatedHeaderDir | None:
115115
"""Try CTK header lookup via CTK-root canary probing.
116116
117117
Skips immediately if the descriptor does not opt in (``use_ctk_root_canary``).
118-
Otherwise, system-loads ``cudart`` in a dedicated Python subprocess, derives
118+
Otherwise, system-loads ``cudart`` in a fully isolated Python subprocess, derives
119119
CTK root from the resolved library path, and searches the expected include
120120
layout under that root.
121121
"""

cuda_pathfinder/docs/source/release/1.4.0-notes.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ Highlights
1212
----------
1313

1414
* Add CTK root canary probing for non-standard-path libraries in
15-
``load_nvidia_dynamic_lib()`` (notably ``nvvm``), including dedicated
16-
subprocess isolation for the canary probe.
15+
``load_nvidia_dynamic_lib()`` (notably ``nvvm``), including spawned child
16+
process isolation for the canary probe.
1717
(`PR #1595 <https://github.com/NVIDIA/cuda-python/pull/1595>`_)
1818

1919
* Restore backward-compatible exception behavior for
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
.. SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
2+
.. SPDX-License-Identifier: Apache-2.0
3+
4+
.. py:currentmodule:: cuda.pathfinder
5+
6+
``cuda-pathfinder`` 1.4.3 Release notes
7+
=======================================
8+
9+
Highlights
10+
----------
11+
12+
* Fix CTK canary probing when it is reached from plain Python scripts that do
13+
not use an ``if __name__ == "__main__"`` guard. The canary now runs in a
14+
fully isolated Python subprocess without re-entering the caller's script
15+
during child-process startup.
16+
(`PR #1768 <https://github.com/NVIDIA/cuda-python/pull/1768>`_)
17+
18+
* Make the canary subprocess resolve ``cuda.pathfinder`` from the same import
19+
root as the parent process. This avoids mixed source-tree versus wheel imports
20+
in wheel-based test environments and keeps the probe behavior consistent
21+
across source and installed-package workflows.
22+
(`PR #1768 <https://github.com/NVIDIA/cuda-python/pull/1768>`_)

0 commit comments

Comments
 (0)