Skip to content

Commit b3ae845

Browse files
cpcloudclaude
cpcloud
and
claude
authored
CI: Test sdist completeness for all user-facing packages on Linux and Windows (#1909)
* CI: Test sdist builds for all user-facing packages Add a new test-sdist workflow that builds an sdist and then a wheel-from-sdist for each of the 4 user-facing packages (cuda_pathfinder, cuda_python, cuda_bindings, cuda_core). This catches regressions in MANIFEST.in or package-data configuration that could silently break sdist-based builds. Closes #1599 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: skip test-sdist job on doc-only PRs Match existing test jobs' doc-only guard so docs-only PRs don't run source-build validation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: point cuda_bindings sdist build at local cuda_pathfinder wheel cuda_bindings build backend imports cuda.pathfinder, so pip's build isolation needs to find the locally-built cuda_pathfinder wheel instead of pulling from PyPI. Set PIP_FIND_LINKS to the pathfinder dist directory. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Add actionlint config for self-hosted runner labels actionlint rejects non-GitHub-hosted runner labels unless declared in .github/actionlint.yaml. This was causing pre-commit.ci failures on test-sdist.yml which uses linux-amd64-cpu8. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * ci: add Windows sdist completeness test alongside Linux Split test-sdist.yml into test-sdist-linux.yml (renamed) and a new test-sdist-windows.yml sibling, mirroring the test-wheel-linux/-windows pattern. cuda_bindings/build_hooks.py selects platform-specific *.pyx variants (_linux.pyx on Linux, _windows.pyx on Windows) at build time, so a Linux-only sdist test cannot prove the sdist ships the Windows sources required to build a wheel-from-sdist on Windows. The Windows variant uses the repo's windows-2022 + ilammy/msvc-dev-cmd setup already used by build-wheel.yml, omits sccache and nv-gha-runners/setup-proxy-cache (both limited to Linux in build-wheel by convention), and otherwise mirrors the Linux steps. ci.yml now invokes both workflows (test-sdist-linux, test-sdist-windows) and the checks aggregator fails if either is cancelled or failed. Addresses review feedback from PR #1909. * ci: normalize Windows PIP_FIND_LINKS via cygpath Convert the find-links paths to native Windows style with cygpath -w so they match the convention used in build-wheel.yml's Windows CIBW environment. This avoids ambiguity when pip splits PIP_FIND_LINKS on spaces and is asked to resolve a mix of path styles. --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent b427919 commit b3ae845

File tree

4 files changed

+246
-0
lines changed

4 files changed

+246
-0
lines changed

‎.github/actionlint.yaml‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
# SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
2+
#
3+
# SPDX-License-Identifier: Apache-2.0
4+
5+
# Self-hosted runner labels used in CI workflows.
6+
# Without this config, actionlint rejects non-GitHub-hosted labels.
7+
self-hosted-runner:
8+
labels:
9+
- linux-amd64-cpu8

‎.github/workflows/ci.yml‎

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -286,6 +286,37 @@ jobs:
286286
cuda-version: ${{ needs.ci-vars.outputs.CUDA_BUILD_VER }}
287287
prev-cuda-version: ${{ needs.ci-vars.outputs.CUDA_PREV_BUILD_VER }}
288288

289+
# NOTE: test-sdist jobs are split by platform (mirroring build-* and test-wheel-*)
290+
# so platform-specific sources (e.g. cuda_bindings/*_windows.pyx selected by
291+
# build_hooks.py) are exercised on their target OS. Keep these job definitions
292+
# textually identical except for:
293+
# - host-platform value
294+
# - uses: (test-sdist-linux.yml vs test-sdist-windows.yml)
295+
test-sdist-linux:
296+
needs:
297+
- ci-vars
298+
- should-skip
299+
name: Test sdist linux-64
300+
if: ${{ github.repository_owner == 'nvidia' && !fromJSON(needs.should-skip.outputs.skip) && !fromJSON(needs.should-skip.outputs.doc-only) }}
301+
secrets: inherit
302+
uses: ./.github/workflows/test-sdist-linux.yml
303+
with:
304+
host-platform: linux-64
305+
cuda-version: ${{ needs.ci-vars.outputs.CUDA_BUILD_VER }}
306+
307+
# See test-sdist-linux for why sdist test jobs are split by platform.
308+
test-sdist-windows:
309+
needs:
310+
- ci-vars
311+
- should-skip
312+
name: Test sdist win-64
313+
if: ${{ github.repository_owner == 'nvidia' && !fromJSON(needs.should-skip.outputs.skip) && !fromJSON(needs.should-skip.outputs.doc-only) }}
314+
secrets: inherit
315+
uses: ./.github/workflows/test-sdist-windows.yml
316+
with:
317+
host-platform: win-64
318+
cuda-version: ${{ needs.ci-vars.outputs.CUDA_BUILD_VER }}
319+
289320
# NOTE: Test jobs are split by platform for the same reason as build jobs (see
290321
# build-linux-64). Keep these job definitions textually identical except for:
291322
# - host-platform value
@@ -388,6 +419,8 @@ jobs:
388419
needs:
389420
- should-skip
390421
- detect-changes
422+
- test-sdist-linux
423+
- test-sdist-windows
391424
- test-linux-64
392425
- test-linux-aarch64
393426
- test-windows
@@ -427,6 +460,12 @@ jobs:
427460
if ${{ needs.doc.result == 'cancelled' || needs.doc.result == 'failure' }}; then
428461
exit 1
429462
fi
463+
if ${{ needs.test-sdist-linux.result == 'cancelled' ||
464+
needs.test-sdist-linux.result == 'failure' ||
465+
needs.test-sdist-windows.result == 'cancelled' ||
466+
needs.test-sdist-windows.result == 'failure' }}; then
467+
exit 1
468+
fi
430469
if [[ "${doc_only}" != "true" ]]; then
431470
if ${{ needs.test-linux-64.result == 'cancelled' ||
432471
needs.test-linux-64.result == 'failure' ||

‎.github/workflows/test-sdist-linux.yml‎

Lines changed: 106 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,106 @@
1+
# SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
2+
#
3+
# SPDX-License-Identifier: Apache-2.0
4+
5+
on:
6+
workflow_call:
7+
inputs:
8+
host-platform:
9+
required: true
10+
type: string
11+
cuda-version:
12+
required: true
13+
type: string
14+
15+
defaults:
16+
run:
17+
shell: bash --noprofile --norc -xeuo pipefail {0}
18+
19+
permissions:
20+
contents: read # This is required for actions/checkout
21+
22+
jobs:
23+
test-sdist:
24+
name: Test sdist builds
25+
runs-on: linux-amd64-cpu8
26+
steps:
27+
- name: Checkout ${{ github.event.repository.name }}
28+
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
29+
with:
30+
fetch-depth: 0
31+
32+
- name: Set up Python
33+
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
34+
with:
35+
python-version: "3.12"
36+
37+
- name: Install build tools
38+
run: pip install build
39+
40+
# Pure Python packages -- no CTK needed.
41+
- name: Build cuda.pathfinder sdist and wheel-from-sdist
42+
run: |
43+
python -m build --sdist cuda_pathfinder/
44+
pip wheel --no-deps --wheel-dir cuda_pathfinder/dist cuda_pathfinder/dist/*.tar.gz
45+
46+
- name: Build cuda-python sdist and wheel-from-sdist
47+
run: |
48+
python -m build --sdist cuda_python/
49+
pip wheel --no-deps --wheel-dir cuda_python/dist cuda_python/dist/*.tar.gz
50+
51+
# Cython packages need CTK + sccache.
52+
# The env vars ACTIONS_CACHE_SERVICE_V2, ACTIONS_RESULTS_URL, and ACTIONS_RUNTIME_TOKEN
53+
# are exposed by this action.
54+
- name: Enable sccache
55+
uses: mozilla-actions/sccache-action@7d986dd989559c6ecdb630a3fd2557667be217ad # 0.0.9
56+
with:
57+
disable_annotations: 'true'
58+
59+
# xref: https://github.com/orgs/community/discussions/42856#discussioncomment-7678867
60+
- name: Adding additional GHA cache-related env vars
61+
uses: actions/github-script@v8
62+
with:
63+
script: |
64+
core.exportVariable('ACTIONS_CACHE_URL', process.env['ACTIONS_CACHE_URL'])
65+
core.exportVariable('ACTIONS_RUNTIME_URL', process.env['ACTIONS_RUNTIME_URL'])
66+
67+
- name: Setup proxy cache
68+
uses: nv-gha-runners/setup-proxy-cache@main
69+
continue-on-error: true
70+
with:
71+
enable-apt: true
72+
73+
- name: Set up mini CTK
74+
uses: ./.github/actions/fetch_ctk
75+
continue-on-error: false
76+
with:
77+
host-platform: ${{ inputs.host-platform }}
78+
cuda-version: ${{ inputs.cuda-version }}
79+
80+
# cuda_bindings/setup.py parses CUDA headers at import time, so CUDA_PATH
81+
# (set by fetch_ctk) must be available for both sdist and wheel builds.
82+
- name: Build cuda.bindings sdist and wheel-from-sdist
83+
run: |
84+
export CUDA_PYTHON_PARALLEL_LEVEL=$(nproc)
85+
export CC="sccache cc"
86+
export CXX="sccache c++"
87+
export PIP_FIND_LINKS="$(pwd)/cuda_pathfinder/dist"
88+
python -m build --sdist cuda_bindings/
89+
pip wheel --no-deps --wheel-dir cuda_bindings/dist cuda_bindings/dist/*.tar.gz
90+
91+
# cuda_core sdist delegates to setuptools (no CTK needed), but
92+
# wheel-from-sdist needs CTK and cuda-bindings (dynamic build dep via
93+
# get_requires_for_build_wheel in build_hooks.py).
94+
- name: Build cuda.core sdist and wheel-from-sdist
95+
run: |
96+
export CUDA_PYTHON_PARALLEL_LEVEL=$(nproc)
97+
export CUDA_CORE_BUILD_MAJOR="$(echo '${{ inputs.cuda-version }}' | cut -d. -f1)"
98+
export CC="sccache cc"
99+
export CXX="sccache c++"
100+
export PIP_FIND_LINKS="$(pwd)/cuda_bindings/dist $(pwd)/cuda_pathfinder/dist"
101+
python -m build --sdist cuda_core/
102+
pip wheel --no-deps --wheel-dir cuda_core/dist cuda_core/dist/*.tar.gz
103+
104+
- name: Show sccache stats
105+
if: always()
106+
run: sccache --show-stats

‎.github/workflows/test-sdist-windows.yml‎

Lines changed: 92 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,92 @@
1+
# SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
2+
#
3+
# SPDX-License-Identifier: Apache-2.0
4+
5+
# Windows counterpart of test-sdist-linux.yml. Exists so that platform-gated
6+
# sources (e.g. cuda_bindings/*_windows.pyx selected by build_hooks.py) are
7+
# exercised by the sdist completeness test. Keep the shape of this file in
8+
# sync with test-sdist-linux.yml aside from Windows-specific setup (MSVC,
9+
# no sccache, no proxy cache).
10+
11+
on:
12+
workflow_call:
13+
inputs:
14+
host-platform:
15+
required: true
16+
type: string
17+
cuda-version:
18+
required: true
19+
type: string
20+
21+
defaults:
22+
run:
23+
shell: bash --noprofile --norc -xeuo pipefail {0}
24+
25+
permissions:
26+
contents: read # This is required for actions/checkout
27+
28+
jobs:
29+
test-sdist:
30+
name: Test sdist builds
31+
runs-on: windows-2022
32+
steps:
33+
- name: Checkout ${{ github.event.repository.name }}
34+
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
35+
with:
36+
fetch-depth: 0
37+
38+
- name: Set up Python
39+
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
40+
with:
41+
python-version: "3.12"
42+
43+
- name: Set up MSVC
44+
uses: ilammy/msvc-dev-cmd@0b201ec74fa43914dc39ae48a89fd1d8cb592756 # v1
45+
46+
- name: Install build tools
47+
run: pip install build
48+
49+
# Pure Python packages -- no CTK needed.
50+
- name: Build cuda.pathfinder sdist and wheel-from-sdist
51+
run: |
52+
python -m build --sdist cuda_pathfinder/
53+
pip wheel --no-deps --wheel-dir cuda_pathfinder/dist cuda_pathfinder/dist/*.tar.gz
54+
55+
- name: Build cuda-python sdist and wheel-from-sdist
56+
run: |
57+
python -m build --sdist cuda_python/
58+
pip wheel --no-deps --wheel-dir cuda_python/dist cuda_python/dist/*.tar.gz
59+
60+
# Cython packages need CTK. No sccache on Windows (this is a correctness
61+
# smoke test, not a production build; see build-wheel.yml which also
62+
# limits sccache to Linux).
63+
- name: Set up mini CTK
64+
uses: ./.github/actions/fetch_ctk
65+
continue-on-error: false
66+
with:
67+
host-platform: ${{ inputs.host-platform }}
68+
cuda-version: ${{ inputs.cuda-version }}
69+
70+
# cuda_bindings/setup.py parses CUDA headers at import time, so CUDA_PATH
71+
# (set by fetch_ctk) must be available for both sdist and wheel builds.
72+
# PIP_FIND_LINKS is passed as a native Windows path via cygpath because
73+
# pip on Windows treats space-separated entries as separators and is
74+
# picky about mixed path styles (see build-wheel.yml for the same
75+
# convention).
76+
- name: Build cuda.bindings sdist and wheel-from-sdist
77+
run: |
78+
export CUDA_PYTHON_PARALLEL_LEVEL=$(nproc)
79+
export PIP_FIND_LINKS="$(cygpath -w "$(pwd)/cuda_pathfinder/dist")"
80+
python -m build --sdist cuda_bindings/
81+
pip wheel --no-deps --wheel-dir cuda_bindings/dist cuda_bindings/dist/*.tar.gz
82+
83+
# cuda_core sdist delegates to setuptools (no CTK needed), but
84+
# wheel-from-sdist needs CTK and cuda-bindings (dynamic build dep via
85+
# get_requires_for_build_wheel in build_hooks.py).
86+
- name: Build cuda.core sdist and wheel-from-sdist
87+
run: |
88+
export CUDA_PYTHON_PARALLEL_LEVEL=$(nproc)
89+
export CUDA_CORE_BUILD_MAJOR="$(echo '${{ inputs.cuda-version }}' | cut -d. -f1)"
90+
export PIP_FIND_LINKS="$(cygpath -w "$(pwd)/cuda_bindings/dist") $(cygpath -w "$(pwd)/cuda_pathfinder/dist")"
91+
python -m build --sdist cuda_core/
92+
pip wheel --no-deps --wheel-dir cuda_core/dist cuda_core/dist/*.tar.gz

0 commit comments

Comments
 (0)