ci: move release-notes checker to ci/tools and drop component=all

Addresses review feedback on #1907:

- Relocate check_release_notes.py (and its tests) from toolshed/ to
  ci/tools/, matching validate-release-wheels which is the closest
  conceptual neighbor. toolshed/ is for scripts we rarely re-run; this
  one is invoked from release.yml on every release.
- Drop the `all` component. The shared-version assumption it encoded no
  longer matches the repo's independent tag families (v*, cuda-core-v*,
  cuda-pathfinder-v*). The broader release-workflow cleanup for `all`
  will happen in a separate pass.
- Register ci/tools/tests under pytest testpaths, and run the unit
  tests in the check-release-notes job before invoking the script.

Author: cpcloud

.github/workflows/release.yml

@@ -102,9 +102,14 @@ jobs:
         with:
           python-version: "3.12"
 
+      - name: Self-test release-notes checker
+        run: |
+          pip install pytest
+          pytest ci/tools/tests
+
       - name: Check versioned release notes exist
         run: |
-          python toolshed/check_release_notes.py \
+          python ci/tools/check_release_notes.py \
             --git-tag "${{ inputs.git-tag }}" \
             --component "${{ inputs.component }}"
 

toolshed/check_release_notes.py ci/tools/check_release_notes.pytoolshed/check_release_notes.py renamed to ci/tools/check_release_notes.py

@@ -7,8 +7,8 @@
     python check_release_notes.py --git-tag <tag> --component <component>
 
 Exit codes:
-    0 — all release notes present and non-empty (or .post version, skipped)
-    1 — one or more release notes missing or empty
+    0 — release notes present and non-empty (or .post version, skipped)
+    1 — release notes missing or empty
     2 — invalid arguments
 """
 
@@ -19,12 +19,11 @@
 import re
 import sys
 
-COMPONENT_TO_PACKAGES: dict[str, list[str]] = {
-    "cuda-core": ["cuda_core"],
-    "cuda-bindings": ["cuda_bindings"],
-    "cuda-pathfinder": ["cuda_pathfinder"],
-    "cuda-python": ["cuda_python"],
-    "all": ["cuda_bindings", "cuda_core", "cuda_pathfinder", "cuda_python"],
+COMPONENT_TO_PACKAGE: dict[str, str] = {
+    "cuda-core": "cuda_core",
+    "cuda-bindings": "cuda_bindings",
+    "cuda-pathfinder": "cuda_pathfinder",
+    "cuda-python": "cuda_python",
 }
 
 # Matches tags like "v13.1.0", "cuda-core-v0.7.0", "cuda-pathfinder-v1.5.2"
@@ -48,7 +47,7 @@ def notes_path(package: str, version: str) -> str:
 def check_release_notes(git_tag: str, component: str, repo_root: str = ".") -> list[tuple[str, str]]:
     """Return a list of (path, reason) for missing or empty release notes.
 
-    Returns an empty list when all notes are present and non-empty.
+    Returns an empty list when notes are present and non-empty.
     """
     version = parse_version_from_tag(git_tag)
     if version is None:
@@ -57,26 +56,23 @@ def check_release_notes(git_tag: str, component: str, repo_root: str = ".") -> l
     if is_post_release(version):
         return []
 
-    packages = COMPONENT_TO_PACKAGES.get(component)
-    if packages is None:
+    package = COMPONENT_TO_PACKAGE.get(component)
+    if package is None:
         return [("<component>", f"unknown component '{component}'")]
 
-    problems = []
-    for pkg in packages:
-        path = notes_path(pkg, version)
-        full = os.path.join(repo_root, path)
-        if not os.path.isfile(full):
-            problems.append((path, "missing"))
-        elif os.path.getsize(full) == 0:
-            problems.append((path, "empty"))
-
-    return problems
+    path = notes_path(package, version)
+    full = os.path.join(repo_root, path)
+    if not os.path.isfile(full):
+        return [(path, "missing")]
+    if os.path.getsize(full) == 0:
+        return [(path, "empty")]
+    return []
 
 
 def main(argv: list[str] | None = None) -> int:
     parser = argparse.ArgumentParser(description=__doc__)
     parser.add_argument("--git-tag", required=True)
-    parser.add_argument("--component", required=True, choices=list(COMPONENT_TO_PACKAGES))
+    parser.add_argument("--component", required=True, choices=list(COMPONENT_TO_PACKAGE))
     parser.add_argument("--repo-root", default=".")
     args = parser.parse_args(argv)
 

…olshed/tests/test_check_release_notes.py …/tools/tests/test_check_release_notes.pytoolshed/tests/test_check_release_notes.py renamed to ci/tools/tests/test_check_release_notes.py toolshed/tests/test_check_release_notes.py renamed to ci/tools/tests/test_check_release_notes.py

@@ -74,20 +74,6 @@ def test_post_release_skipped(self, tmp_path):
         problems = check_release_notes("v12.6.2.post1", "cuda-bindings", str(tmp_path))
         assert problems == []
 
-    def test_component_all(self, tmp_path):
-        for pkg in ("cuda_bindings", "cuda_core", "cuda_pathfinder", "cuda_python"):
-            self._make_notes(tmp_path, pkg, "13.1.0")
-        problems = check_release_notes("v13.1.0", "all", str(tmp_path))
-        assert problems == []
-
-    def test_component_all_partial_missing(self, tmp_path):
-        self._make_notes(tmp_path, "cuda_bindings", "13.1.0")
-        self._make_notes(tmp_path, "cuda_core", "13.1.0")
-        problems = check_release_notes("v13.1.0", "all", str(tmp_path))
-        assert len(problems) == 2
-        missing_pkgs = {p.split("/")[0] for p, _ in problems}
-        assert missing_pkgs == {"cuda_pathfinder", "cuda_python"}
-
     def test_invalid_tag(self, tmp_path):
         problems = check_release_notes("not-a-tag", "cuda-core", str(tmp_path))
         assert len(problems) == 1

pytest.ini

@@ -12,6 +12,7 @@ testpaths =
     cuda_bindings/tests
     cuda_core/tests
     tests/integration
+    ci/tools/tests
 
 markers =
     pathfinder: tests for cuda_pathfinder