@@ -84,28 +84,28 @@ jobs:
8484 echo '```'
8585 }
8686
87- HAS_TRUE_POSITIVE_SIGNAL =false
87+ HAS_TRUSTED_SIGNAL =false
8888 ALLOWLIST_CHECK="not needed (no restricted paths)"
8989 LABEL_ACTION="not needed (no restricted paths)"
90- TRUE_POSITIVE_SIGNALS ="(none)"
90+ TRUSTED_SIGNALS ="(none)"
9191 PR_AUTHOR_CANONICAL=${PR_AUTHOR,,}
9292
9393 if [ "$TOUCHES_RESTRICTED_PATHS" = "true" ]; then
9494 case "$AUTHOR_ASSOCIATION" in
9595 MEMBER|OWNER)
96- HAS_TRUE_POSITIVE_SIGNAL =true
97- ALLOWLIST_CHECK="skipped (author association is a true positive )"
98- LABEL_ACTION="not needed (author association is a true positive )"
99- TRUE_POSITIVE_SIGNALS ="author_association:$AUTHOR_ASSOCIATION"
96+ HAS_TRUSTED_SIGNAL =true
97+ ALLOWLIST_CHECK="skipped (author association is a trusted signal )"
98+ LABEL_ACTION="not needed (author association is a trusted signal )"
99+ TRUSTED_SIGNALS ="author_association:$AUTHOR_ASSOCIATION"
100100 ;;
101101 esac
102102
103- if [ "$HAS_TRUE_POSITIVE_SIGNAL " = "false" ]; then
103+ if [ "$HAS_TRUSTED_SIGNAL " = "false" ]; then
104104 if printf '%s\n' "$INTERNAL_AUTHOR_ALLOWLIST" | tr '[:upper:]' '[:lower:]' | grep -Fxq "$PR_AUTHOR_CANONICAL"; then
105- HAS_TRUE_POSITIVE_SIGNAL =true
105+ HAS_TRUSTED_SIGNAL =true
106106 ALLOWLIST_CHECK="matched ($PR_AUTHOR_CANONICAL)"
107- LABEL_ACTION="not needed (workflow allowlist is a true positive )"
108- TRUE_POSITIVE_SIGNALS ="workflow_allowlist:$PR_AUTHOR_CANONICAL"
107+ LABEL_ACTION="not needed (workflow allowlist is a trusted signal )"
108+ TRUSTED_SIGNALS ="workflow_allowlist:$PR_AUTHOR_CANONICAL"
109109 else
110110 ALLOWLIST_CHECK="not matched ($PR_AUTHOR_CANONICAL)"
111111 fi
@@ -117,7 +117,7 @@ jobs:
117117 LABEL_ALREADY_PRESENT=true
118118 fi
119119
120- if [ "$TOUCHES_RESTRICTED_PATHS" = "true" ] && [ "$HAS_TRUE_POSITIVE_SIGNAL " = "false" ]; then
120+ if [ "$TOUCHES_RESTRICTED_PATHS" = "true" ] && [ "$HAS_TRUSTED_SIGNAL " = "false" ]; then
121121 if [ "$LABEL_ALREADY_PRESENT" = "true" ]; then
122122 LABEL_ACTION="already present"
123123 elif ! gh issue edit "$PR_NUMBER" --repo "$REPO" --add-label "$REVIEW_LABEL"; then
@@ -148,14 +148,14 @@ jobs:
148148 echo "- **Touches restricted paths**: $TOUCHES_RESTRICTED_PATHS"
149149 echo "- **Restricted paths**: \`cuda_bindings/\`, \`cuda_python/\`"
150150 echo "- **Allowlist check**: $ALLOWLIST_CHECK"
151- echo "- **True positive signals**: $TRUE_POSITIVE_SIGNALS "
151+ echo "- **Trusted signals**: $TRUSTED_SIGNALS "
152152 echo "- **Label action**: $LABEL_ACTION"
153153 if [ "$TOUCHES_RESTRICTED_PATHS" = "true" ]; then
154154 echo ""
155155 write_matching_restricted_paths
156156 fi
157- if [ "$TOUCHES_RESTRICTED_PATHS" = "true" ] && [ "$HAS_TRUE_POSITIVE_SIGNAL " = "false" ]; then
157+ if [ "$TOUCHES_RESTRICTED_PATHS" = "true" ] && [ "$HAS_TRUSTED_SIGNAL " = "false" ]; then
158158 echo ""
159- echo "- **Manual follow-up**: No true positive signal was found, so \`$REVIEW_LABEL\` is required."
159+ echo "- **Manual follow-up**: No trusted signal was found, so \`$REVIEW_LABEL\` is required."
160160 fi
161161 } >> "$GITHUB_STEP_SUMMARY"
0 commit comments