Skip to content

Commit cd15d84

Browse files
committed
Improve Cpp harness with min-time for more stable collection
1 parent daf603d commit cd15d84

1 file changed

Lines changed: 2 additions & 10 deletions

File tree

benchmarks/cuda_bindings/compare.py

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -71,12 +71,6 @@ def main() -> None:
7171
default=DEFAULT_CPP,
7272
help=f"C++ results JSON (default: {DEFAULT_CPP.name})",
7373
)
74-
parser.add_argument(
75-
"--target-us",
76-
type=float,
77-
default=1.0,
78-
help="Overhead target in microseconds (default: 1.0)",
79-
)
8074
args = parser.parse_args()
8175

8276
if not args.python.exists():
@@ -100,7 +94,7 @@ def main() -> None:
10094
if cpp_benchmarks:
10195
header = (
10296
f"{'Benchmark':<{name_width}} {'C++ (mean)':>12} {'C++ RSD':>8} "
103-
f"{'Python (mean)':>14} {'Py RSD':>7} {'Overhead':>10} {'Target':>6}"
97+
f"{'Python (mean)':>14} {'Py RSD':>7} {'Overhead':>10}"
10498
)
10599
sep = "-" * len(header)
106100
print(sep)
@@ -130,15 +124,13 @@ def main() -> None:
130124
cpp_mean = cpp_stats[0]
131125
overhead_ns = (py_mean - cpp_mean) * 1e9
132126
overhead_str = f"+{overhead_ns:.0f} ns"
133-
target = "OK" if overhead_ns <= args.target_us * 1000 else "FAIL"
134127
else:
135128
overhead_str = "-"
136-
target = "-"
137129

138130
if cpp_benchmarks:
139131
print(
140132
f"{name:<{name_width}} {cpp_str:>12} {cpp_rsd:>8} "
141-
f"{py_str:>14} {py_rsd:>7} {overhead_str:>10} {target:>6}"
133+
f"{py_str:>14} {py_rsd:>7} {overhead_str:>10}"
142134
)
143135
else:
144136
print(f"{name:<{name_width}} {py_str:>14} {py_rsd:>7}")

0 commit comments

Comments
 (0)