Skip to content

Commit db45d36

Browse files
committed
refactor(pathfinder): apply info_log rename to new upstream tests
test_driver_lib_loading.py, test_find_bitcode_lib.py, and test_find_static_lib.py landed on main while this branch was open and still reference the info_summary_append fixture that this PR removes. Switch them to the info_log LoggerAdapter fixture so the rename is complete across the pathfinder test suite.
1 parent 93373c4 commit db45d36

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

cuda_pathfinder/tests/test_driver_lib_loading.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ def test_load_lib_no_cache_does_not_dispatch_ctk_lib_to_driver_path(mocker):
127127

128128

129129
@pytest.mark.parametrize("libname", sorted(_DRIVER_ONLY_LIBNAMES))
130-
def test_real_load_driver_lib(info_summary_append, libname):
130+
def test_real_load_driver_lib(info_log, libname):
131131
"""Load a real driver library in a dedicated subprocess.
132132
133133
This complements the mock tests above: it exercises the actual OS
@@ -151,9 +151,9 @@ def raise_child_process_failed():
151151
skip_if_missing_libnvcudla_so(libname, timeout=timeout)
152152
if STRICTNESS == "all_must_work":
153153
raise_child_process_failed()
154-
info_summary_append(f"Not found: {libname=!r}")
154+
info_log.info(f"Not found: {libname=!r}")
155155
else:
156156
abs_path = payload.abs_path
157157
assert abs_path is not None
158-
info_summary_append(f"abs_path={quote_for_shell(abs_path)}")
158+
info_log.info(f"abs_path={quote_for_shell(abs_path)}")
159159
assert os.path.isfile(abs_path)

cuda_pathfinder/tests/test_find_bitcode_lib.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,17 +60,17 @@ def _located_bitcode_lib_asserts(located_bitcode_lib):
6060

6161
@pytest.mark.usefixtures("clear_find_bitcode_lib_cache")
6262
@pytest.mark.parametrize("libname", SUPPORTED_BITCODE_LIBS)
63-
def test_locate_bitcode_lib(info_summary_append, libname):
63+
def test_locate_bitcode_lib(info_log, libname):
6464
try:
6565
located_lib = locate_bitcode_lib(libname)
6666
lib_path = find_bitcode_lib(libname)
6767
except BitcodeLibNotFoundError:
6868
if STRICTNESS == "all_must_work":
6969
raise
70-
info_summary_append(f"{libname}: not found")
70+
info_log.info(f"{libname}: not found")
7171
return
7272

73-
info_summary_append(f"{lib_path=!r}")
73+
info_log.info(f"{lib_path=!r}")
7474
_located_bitcode_lib_asserts(located_lib)
7575
assert os.path.isfile(lib_path)
7676
assert lib_path == located_lib.abs_path

cuda_pathfinder/tests/test_find_static_lib.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,17 +57,17 @@ def _located_static_lib_asserts(located_static_lib):
5757

5858
@pytest.mark.usefixtures("clear_find_static_lib_cache")
5959
@pytest.mark.parametrize("libname", SUPPORTED_STATIC_LIBS)
60-
def test_locate_static_lib(info_summary_append, libname):
60+
def test_locate_static_lib(info_log, libname):
6161
try:
6262
located_lib = locate_static_lib(libname)
6363
lib_path = find_static_lib(libname)
6464
except StaticLibNotFoundError:
6565
if STRICTNESS == "all_must_work":
6666
raise
67-
info_summary_append(f"{libname}: not found")
67+
info_log.info(f"{libname}: not found")
6868
return
6969

70-
info_summary_append(f"abs_path={quote_for_shell(lib_path)}")
70+
info_log.info(f"abs_path={quote_for_shell(lib_path)}")
7171
_located_static_lib_asserts(located_lib)
7272
assert os.path.isfile(lib_path)
7373
assert lib_path == located_lib.abs_path

0 commit comments

Comments
 (0)