Fix command line arguments for linker and compiler (#895)

* Fix command line arguments checking related to optimization, debugging, and lineinfo.
Fix ProgramOptions.__repr__() to return a string instead of a list.

* pre-commit formatting fix

Author: mmason-nvidia

cuda_core/cuda/core/experimental/_linker.py

@@ -205,15 +205,15 @@ def _init_nvjitlink(self):
             self.formatted_options.append("-time")
         if self.verbose is not None:
             self.formatted_options.append("-verbose")
-        if self.link_time_optimization is not None:
+        if self.link_time_optimization is not None and self.link_time_optimization:
             self.formatted_options.append("-lto")
         if self.ptx is not None:
             self.formatted_options.append("-ptx")
         if self.optimization_level is not None:
             self.formatted_options.append(f"-O{self.optimization_level}")
-        if self.debug is not None:
+        if self.debug is not None and self.debug:
             self.formatted_options.append("-g")
-        if self.lineinfo is not None:
+        if self.lineinfo is not None and self.lineinfo:
             self.formatted_options.append("-lineinfo")
         if self.ftz is not None:
             self.formatted_options.append(f"-ftz={'true' if self.ftz else 'false'}")

cuda_core/cuda/core/experimental/_program.py

@@ -244,8 +244,8 @@ def __post_init__(self):
             self._formatted_options.append("--device-debug")
         if self.lineinfo is not None and self.lineinfo:
             self._formatted_options.append("--generate-line-info")
-        if self.device_code_optimize is not None:
-            self._formatted_options.append(f"--dopt={'on' if self.device_code_optimize else 'off'}")
+        if self.device_code_optimize is not None and self.device_code_optimize:
+            self._formatted_options.append("--dopt=on")
         if self.ptxas_options is not None:
             opt_name = "--ptxas-options"
             if isinstance(self.ptxas_options, str):
@@ -351,7 +351,7 @@ def _as_bytes(self):
 
     def __repr__(self):
         # __TODO__ improve this
-        return self._formatted_options
+        return str(self._formatted_options)
 
 
 ProgramHandleT = Union["cuda.bindings.nvrtc.nvrtcProgram", LinkerHandleT]