Resolve review comments about naming

Author: vzhurba01

cuda_core/cuda/core/experimental/__init__.py

@@ -5,7 +5,7 @@
 from cuda.core.experimental import utils
 from cuda.core.experimental._device import Device
 from cuda.core.experimental._event import Event, EventOptions
-from cuda.core.experimental._graph import CompleteOptions, DebugPrintOptions, Graph, GraphBuilder, launch_graph
+from cuda.core.experimental._graph import GraphCompleteOptions, GraphDebugPrintOptions, Graph, GraphBuilder, launch_graph
 from cuda.core.experimental._launch_config import LaunchConfig
 from cuda.core.experimental._launcher import launch
 from cuda.core.experimental._linker import Linker, LinkerOptions

cuda_core/cuda/core/experimental/_graph.py

@@ -33,7 +33,7 @@ def _lazy_init():
 
 
 @dataclass
-class DebugPrintOptions:
+class GraphDebugPrintOptions:
     """Customizable options for :obj:`_graph.GraphBuilder.debug_dot_print()`
 
     Attributes
@@ -92,7 +92,7 @@ class DebugPrintOptions:
 
 
 @dataclass
-class CompleteOptions:
+class GraphCompleteOptions:
     """Customizable options for :obj:`_graph.GraphBuilder.complete()`
 
     Attributes
@@ -262,12 +262,12 @@ def end_building(self) -> GraphBuilder:
         self._building_ended = True
         return self
 
-    def complete(self, options: Optional[CompleteOptions] = None) -> Graph:
+    def complete(self, options: Optional[GraphCompleteOptions] = None) -> Graph:
         """Completes the graph builder and returns the built :obj:`~_graph.Graph` object.
 
         Parameters
         ----------
-        options : :obj:`~_graph.CompleteOptions`, optional
+        options : :obj:`~_graph.GraphCompleteOptions`, optional
             Customizable dataclass for the graph builder completion options.
 
         Returns
@@ -324,14 +324,14 @@ def complete(self, options: Optional[CompleteOptions] = None) -> Graph:
             raise RuntimeError(f"Graph instantiation failed with unexpected error code: {params.result_out}")
         return graph
 
-    def debug_dot_print(self, path, options: Optional[DebugPrintOptions] = None):
+    def debug_dot_print(self, path, options: Optional[GraphDebugPrintOptions] = None):
         """Generates a DOT debug file for the graph builder.
 
         Parameters
         ----------
         path : str
             File path to use for writting debug DOT output
-        options : :obj:`~_graph.DebugPrintOptions`, optional
+        options : :obj:`~_graph.GraphDebugPrintOptions`, optional
             Customizable dataclass for the debug print options.
 
         """
@@ -768,12 +768,6 @@ def launch_graph(parent_graph: GraphBuilder, child_graph: GraphBuilder):
     if not parent_graph.is_building:
         raise ValueError("Parent graph is being built.")
 
-    status, _, graph_out, dependencies_out, num_dependencies_out = handle_return(
-        driver.cuStreamGetCaptureInfo(parent_graph.stream.handle)
-    )
-    if status != driver.CUstreamCaptureStatus.CU_STREAM_CAPTURE_STATUS_ACTIVE:
-        raise ValueError("Parent graph is not in an active capture state")
-
     child_node = handle_return(
         driver.cuGraphAddChildGraphNode(graph_out, dependencies_out, num_dependencies_out, child_graph._mnff.graph)
     )

cuda_core/tests/test_graph.py

@@ -10,8 +10,8 @@
 except ImportError:
     from cuda import nvrtc
 from cuda.core.experimental import (
-    CompleteOptions,
-    DebugPrintOptions,
+    GraphCompleteOptions,
+    GraphDebugPrintOptions,
     Device,
     GraphBuilder,
     LaunchConfig,
@@ -690,7 +690,7 @@ def test_graph_dot_print_options(init_cuda, tmp_path):
 
     # Print using all options
     path = bytes(str(tmp_path / "vlad.dot"), "utf-8")
-    options = DebugPrintOptions(**{field: True for field in DebugPrintOptions.__dataclass_fields__})
+    options = GraphDebugPrintOptions(**{field: True for field in GraphDebugPrintOptions.__dataclass_fields__})
     gb.debug_dot_print(path, options)
 
 
@@ -706,13 +706,13 @@ def test_graph_complete_options(init_cuda):
     launch(gb, LaunchConfig(grid=1, block=1), empty_kernel)
     gb.end_building()
 
-    options = CompleteOptions(auto_free_on_launch=True)
+    options = GraphCompleteOptions(auto_free_on_launch=True)
     gb.complete(options).close()
-    options = CompleteOptions(upload_stream=launch_stream)
+    options = GraphCompleteOptions(upload_stream=launch_stream)
     gb.complete(options).close()
-    options = CompleteOptions(device_launch=True)
+    options = GraphCompleteOptions(device_launch=True)
     gb.complete(options).close()
-    options = CompleteOptions(use_node_priority=True)
+    options = GraphCompleteOptions(use_node_priority=True)
     gb.complete(options).close()