Address comments in the PR

Author: mdboom

cuda_core/cuda/core/system/_device.pyx

@@ -686,6 +686,8 @@ cdef class Device:
 
         For devices with NVLink support.
         """
+        if link < 0 or link >= NvlinkInfo.max_links:
+            raise ValueError(f"Link index {link} is out of range [0, {NvlinkInfo.max_links})")
         return NvlinkInfo(self, link)
 
     ##########################################################################

cuda_core/cuda/core/system/_nvlink.pxi

@@ -18,32 +18,32 @@ cdef class NvlinkInfo:
         self._link = link
 
     @property
-    def version(self) -> NvLinkVersion:
+    def version(self) -> NvlinkVersion:
         """
-        Retrieves the :obj:`~NvLinkVersion` for the device and link.
+        Retrieves the :obj:`~NvlinkVersion` for the device and link.
 
         For all products with NvLink support.
 
         Returns
         -------
-        NvLinkVersion
-            The NvLink version.
+        NvlinkVersion
+            The Nvlink version.
         """
         return NvlinkVersion(nvml.device_get_nvlink_version(self._device._handle, self._link))
 
     @property
     def state(self) -> bool:
         """
-        Retrieves the state of the device's NvLink for the device and link specified.
+        Retrieves the state of the device's Nvlink for the device and link specified.
 
         For Pascal™ or newer fully supported devices.
 
-        For all products with NvLink support.
+        For all products with Nvlink support.
 
         Returns
         -------
         bool
-            `True` if the NvLink is active.
+            `True` if the Nvlink is active.
         """
         return (
             nvml.device_get_nvlink_state(self._device._handle, self._link) == nvml.EnableState.FEATURE_ENABLED

cuda_core/tests/system/test_system_device.py

@@ -746,6 +746,10 @@ def test_nvlink():
                 version = nvlink_info.version
             assert isinstance(version, system.NvlinkVersion)
 
+            with unsupported_before(device, None):
+                state = nvlink_info.state
+            assert isinstance(state, bool)
+
 
 def test_utilization():
     for device in system.Device.get_all_devices():