Skip to content

[no-ci] Fix race condition in PR metadata check workflow #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leofang merged 3 commits into from
Apr 7, 2026
+12 −3
Merged

[no-ci] Fix race condition in PR metadata check workflow #1874

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ff9dc6
Fix race condition in PR metadata check workflow
leofang Apr 7, 2026
ee3e7a8
Use --jq to filter gh api response to only needed fields
leofang Apr 7, 2026
f1850e0
Use gh pr view instead of gh api for cleaner PR data fetch
leofang Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions .github/workflows/pr-metadata-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ jobs:
steps:
- name: Check for assignee, labels, and milestone
env:
ASSIGNEES: ${{ toJson(github.event.pull_request.assignees) }}
LABELS: ${{ toJson(github.event.pull_request.labels) }}
MILESTONE: ${{ github.event.pull_request.milestone && github.event.pull_request.milestone.title || '' }}
PR_URL: ${{ github.event.pull_request.html_url }}
PR_NUMBER: ${{ github.event.pull_request.number }}
GH_REPO: ${{ github.repository }}
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
IS_BOT: ${{ github.actor == 'dependabot[bot]' || github.actor == 'pre-commit-ci[bot]' || github.actor == 'copy-pr-bot[bot]' }}
IS_DRAFT: ${{ github.event.pull_request.draft }}
run: |
Expand All @@ -37,6 +37,15 @@ jobs:
exit 0
fi

# Fetch live PR data to avoid stale event payload (race condition
# when labels/milestone are added shortly after PR creation).
PR_JSON=$(gh pr view "${PR_NUMBER}" --repo "${GH_REPO}" \
--json assignees,labels,milestone \
--jq '{assignees: .assignees, labels: .labels, milestone: (.milestone.title // empty)}')
ASSIGNEES=$(echo "$PR_JSON" | jq '.assignees')
LABELS=$(echo "$PR_JSON" | jq '.labels')
MILESTONE=$(echo "$PR_JSON" | jq -r '.milestone')

ERRORS=""

ASSIGNEE_COUNT=$(echo "$ASSIGNEES" | jq 'length')
Expand Down
Loading